From owner-svn-src-all@freebsd.org Fri May 25 20:08:58 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A4B8FEF2FFF; Fri, 25 May 2018 20:08:58 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2A5E871EC9; Fri, 25 May 2018 20:08:58 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id EA6747B84; Fri, 25 May 2018 20:08:57 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 248B9419; Fri, 25 May 2018 20:08:57 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id ORu45hOl6a9y; Fri, 25 May 2018 20:08:54 +0000 (UTC) To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com 16BFB414 References: <201805240430.w4O4U6Js001134@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... Message-ID: Date: Fri, 25 May 2018 13:08:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201805240430.w4O4U6Js001134@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 20:08:58 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o Content-Type: multipart/mixed; boundary="nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio"; protected-headers="v1" From: Bryan Drewery To: Matt Macy , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: Subject: Re: svn commit: r334128 - in head: . lib/libpmcstat lib/libpmcstat/pmu-events lib/libpmcstat/pmu-events/arch lib/libpmcstat/pmu-events/arch/arm64 lib/libpmcstat/pmu-events/arch/arm64/arm lib/libpmcstat... References: <201805240430.w4O4U6Js001134@repo.freebsd.org> In-Reply-To: <201805240430.w4O4U6Js001134@repo.freebsd.org> --nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/23/2018 9:30 PM, Matt Macy wrote: > Author: mmacy > Date: Thu May 24 04:30:06 2018 > New Revision: 334128 > URL: https://svnweb.freebsd.org/changeset/base/334128 >=20 > Log: > libpmcstat: compile in events based on json description >=20 > Added: > head/lib/libpmcstat/libpmcstat_pmu_util.c (contents, props changed)= > head/lib/libpmcstat/pmu-events/ > head/lib/libpmcstat/pmu-events/Makefile (contents, props changed) =2E.. > # cat lib/libpmcstat/pmu-events/Makefile > # $FreeBSD$ >=20 > PROG=3Djevents > SRCS=3Djevents.c jsmn.c json.c > CFLAGS+=3D -Wno-cast-qual > .PATH: ${.CURDIR} > build-tools: jevents > MAN=3D > .include Several things wrong here and in lib/libpmcstat/Makefile 1. Newlines? Existing style from other Makefiles? style.Makefile(5) 2. .PATH implicitly has .CURDIR in it already. 3. Need special META_MODE handling for the build-tools target. I don't necessarily expect people to get this right but every other use of build-tools in the tree has a pattern that isn't used here. 4. You used HOST_OBJTOP in lib/libpmcstat/Makefile to refer to jevents for some reason when nothing else does. This is really just the META_MODE pattern being wrong. I'm fixing all of this. --=20 Regards, Bryan Drewery --nLTYkr8l3ZYwmGdN808jGQfO2df1OzYio-- --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbCG1WAAoJEDXXcbtuRpfP76YH/0Vxv6knMWSVssAb/SMNY8yr PqpAaqVAEWZVnmizQXC3QBY8cRGNxHc28q218FSRfLBIuAeDSU0wTQbFi/1ekxv4 nv+ThkPKqsQGWTv9z/q4nUfFUSzqIUES+y4oI5ezoxQBNJQKB8kL4NPLYzAcajTa dWcZSC9g4Y9gTPbayIN+SiOXZpuAsTIMW7USHbe1LQ6LqdMELchKPcSJbJAOY94n 19BEoD1wQHlECVldpVuFtpAMVDBPQDRTpp33RdHWT3ovKWnH5pvBHvjdqVrJH73S f/Be4rsw0vmBJLeiOddUQlF+KwmcaUfidMsoBzzhuXKyLwiyx0e0z9/tmicAgIk= =5eOP -----END PGP SIGNATURE----- --5A7xcxOCbMT9DXKZfXWZcU8v889phVa5o--