From owner-cvs-all@FreeBSD.ORG  Mon Jun 25 21:42:07 2012
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by hub.freebsd.org (Postfix) with ESMTP id B5B3A106566C;
	Mon, 25 Jun 2012 21:42:07 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36])
	by mx2.freebsd.org (Postfix) with ESMTP id 7B22714FA25;
	Mon, 25 Jun 2012 21:40:38 +0000 (UTC)
Message-ID: <4FE8DAD6.9030107@FreeBSD.org>
Date: Mon, 25 Jun 2012 14:40:38 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:12.0) Gecko/20120430 Thunderbird/12.0.1
MIME-Version: 1.0
To: Hajimu UMEMOTO <ume@FreeBSD.org>
References: <201206251606.q5PG6IGG003814@repoman.freebsd.org>
In-Reply-To: <201206251606.q5PG6IGG003814@repoman.freebsd.org>
X-Enigmail-Version: 1.4.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Masaki TAGAWA <masaki@club.kyutech.ac.jp>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/japanese/tiarra Makefile
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jun 2012 21:42:07 -0000

Because the script runs as an unprivileged user, this:

# REQUIRE: DAEMON
# BEFORE: LOGIN

should be replaced with:

# REQUIRE: LOGIN

Otherwise the script looks pretty good.

Also, ume, please don't obscure e-mail addresses in commit logs. It does
nothing to confuse spammers, but does make it more difficult to paste
them into a message.

hope this helps,

Doug


On 06/25/2012 09:06 AM, Hajimu UMEMOTO wrote:
> ume         2012-06-25 16:06:18 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     japanese/tiarra      Makefile 
>   Log:
>   Fix SUB_LIST to work rc.d script properly.
>   
>   PR:             ports/169387  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=169387
>   Submitted by:   Masaki TAGAWA <masaki__at__club.kyutech.ac.jp>
>   
>   Revision  Changes    Path
>   1.9       +2 -1      ports/japanese/tiarra/Makefile
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/japanese/tiarra/Makefile.diff?&r1=1.8&r2=1.9&f=u
>