Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 May 2018 07:07:36 +0000
From:      bugzilla-noreply@freebsd.org
To:        multimedia@FreeBSD.org
Subject:   [Bug 228265] audio/fluidsynth: Update to 1.1.11
Message-ID:  <bug-228265-12827-RLHWmO2LKk@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-228265-12827@https.bugs.freebsd.org/bugzilla/>
References:  <bug-228265-12827@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228265

Tobias Kortkamp <tobik@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik@freebsd.org

--- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> ---
This completely breaks sndio support.  This change to patch-CMakeLists.txt
is wrong:

++    unset ( SNDIO_SUPPORT CACHE )
++    if ( enable-sndio )
++    pkg_check_modules ( SNDIO libsndio>=3D1.4.0 )
++    set ( SNDIO_SUPPORT ${SNDIO_FOUND} )
++    else ( enable-sndio )
++    unset_pkg_config ( SNDIO )
++    endif ( enable-sndio )

sndio doesn't come with a pkg-config file, so I'm not sure why this was
changed to use pkg_check_modules.  Please keep it like before.  This bit

-+unset ( SNDIO_SUPPORT CACHE )
-+if ( enable-sndio )
-+  set ( SNDIO_SUPPORT 1 )
-+endif ( enable-sndio )

needs to stay like it was.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228265-12827-RLHWmO2LKk>