From owner-cvs-all Mon Jan 13 0:25:57 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FE6837B401; Mon, 13 Jan 2003 00:25:56 -0800 (PST) Received: from milla.ask33.net (milla.ask33.net [217.197.166.60]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8F76943F13; Mon, 13 Jan 2003 00:25:55 -0800 (PST) (envelope-from nick@milla.ask33.net) Received: by milla.ask33.net (Postfix, from userid 1001) id 08F433ABB65; Mon, 13 Jan 2003 09:26:10 +0100 (CET) Date: Mon, 13 Jan 2003 09:26:10 +0100 From: Pawel Jakub Dawidek To: Matthew Dillon Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/ipfw ipfw.8 ipfw2.c Message-ID: <20030113082610.GH9430@garage.freebsd.pl> References: <200301120331.h0C3VA2H040455@repoman.freebsd.org> <20030113075934.GE9430@garage.freebsd.pl> <200301130807.h0D87urr001783@apollo.backplane.com> <20030113081749.GF9430@garage.freebsd.pl> <200301130819.h0D8JsJc001902@apollo.backplane.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="WK3l2KTTmXPVedZ6" Content-Disposition: inline In-Reply-To: <200301130819.h0D8JsJc001902@apollo.backplane.com> X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc X-OS: FreeBSD 4.7-STABLE i386 User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --WK3l2KTTmXPVedZ6 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 13, 2003 at 12:19:54AM -0800, Matthew Dillon wrote: +> You are looking at the old ipfw code. Look at the sysctl's in +> ip_fw2.c instead. Either way it is not really relevant to my +> commit, I didn't make any changes to the IPFW kernel code, only=20 +> to the userland program. Sorry. But IMHO in ip_fw2.c this sysctl works bad as well. CTLFLAG_SECURE prevent from changing sysctl when securelevel >=3D 0 and this prevention should be only when >=3D 3. But sysctl definition in ip_fw.c is bad, right? If yes, maybe some PR should be sent? --=20 Pawel Jakub Dawidek UNIX Systems Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am. --WK3l2KTTmXPVedZ6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBPiJ4Ij/PhmMH/Mf1AQEkbgP/fXfn6kVjk6pxLe61xBorDy0wkf1mLi1m iEk/PYYrsvzcVs0UCocnL5AC+WWmuB67et9/xeLhOpmBqtDGMo300cmVWn6l5WfK L7myMBv/mS6JeP1P9MigcZctZSFXBpxYyE/g3gkfXoH5V9d+w99qgDT0CiVdsJq2 WpvlrK+Ney0= =wjvO -----END PGP SIGNATURE----- --WK3l2KTTmXPVedZ6-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message