Date: Fri, 18 Dec 2009 02:40:22 GMT From: Glen Barber <glen.j.barber@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/141730: [patch] audio/akode-plugins-mpeg: Makefile fixes for portlint Message-ID: <200912180240.nBI2eMRI038290@www.freebsd.org> Resent-Message-ID: <200912180250.nBI2o2ND020609@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 141730
>Category: ports
>Synopsis: [patch] audio/akode-plugins-mpeg: Makefile fixes for portlint
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: update
>Submitter-Id: current-users
>Arrival-Date: Fri Dec 18 02:50:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Glen Barber
>Release: 8.0-STABLE
>Organization:
>Environment:
FreeBSD orion 8.0-STABLE FreeBSD 8.0-STABLE #9 r200334: Wed Dec 9 19:02:03 EST 2009 root@orion:/usr/obj/usr/src/sys/ORION amd64
>Description:
portlint finds FATAL errors in the Makefile for this port, such as:
- use a tab (not space) after a variable name
- extra item placed in the PORTNAME section
- extra item placed in the MAINTAINER section
Additionally, portlint warns PLIST_FLAGS should be used when pkg-plist contains 6 or less entries.
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
diff -ruN /usr/ports/audio/akode-plugins-mpeg/Makefile /usr/local/ports/audio/akode-plugins-mpeg/Makefile
--- /usr/ports/audio/akode-plugins-mpeg/Makefile 2009-08-02 15:32:10.000000000 -0400
+++ /usr/local/ports/audio/akode-plugins-mpeg/Makefile 2009-12-17 21:04:05.000000000 -0500
@@ -5,15 +5,14 @@
# $FreeBSD: ports/audio/akode-plugins-mpeg/Makefile,v 1.22 2009/08/02 19:32:10 mezz Exp $
#
-PORTNAME= akode-plugins-${PORTNAMESUFX}
-PORTVERSION= 2.0.2
-PORTEPOCH= 1
-CATEGORIES= audio kde
-MASTER_SITES= ${MASTER_SITE_GENTOO}
-MASTER_SITE_SUBDIR=distfiles
-DISTNAME= 30375-akode-${PORTVERSION}.tar.bz2
-
-EXTRACT_SUFX= # none
+PORTNAME= akode-plugins-${PORTNAMESUFX}
+PORTVERSION= 2.0.2
+PORTEPOCH= 1
+CATEGORIES= audio kde
+MASTER_SITES= ${MASTER_SITE_GENTOO}
+MASTER_SITE_SUBDIR= distfiles
+DISTNAME= 30375-akode-${PORTVERSION}.tar.bz2
+EXTRACT_SUFX=
MAINTAINER= kde@FreeBSD.org
COMMENT= MPEG audio decoder plugin for akode
@@ -26,12 +25,16 @@
PORTNAMESUFX= ${PLUGIN:S/_sink//:S/_decoder//:S/src_//}
USE_AUTOTOOLS= libltdl
-USE_AUTOTOOLS= libtool:22
+USE_AUTOTOOLS= libtool:22
USE_BZIP2= yes
USE_GMAKE= yes
WRKSRC= ${WRKDIR}/akode-${PORTVERSION}
USE_LDCONFIG= yes
+PLIST_FILES= lib/libakode_mpeg_decoder.a \
+ lib/libakode_mpeg_decoder.la \
+ lib/libakode_mpeg_decoder.so
+
CONFIGURE_ENV+= LDFLAGS=-L${WRKSRC}/akode/lib/.libs
CONFIGURE_ARGS+=--with-extra-libs=${LOCALBASE}/lib \
--with-extra-includes=${LOCALBASE}/include
diff -ruN /usr/ports/audio/akode-plugins-mpeg/pkg-plist /usr/local/ports/audio/akode-plugins-mpeg/pkg-plist
--- /usr/ports/audio/akode-plugins-mpeg/pkg-plist 2006-03-30 15:30:01.000000000 -0500
+++ /usr/local/ports/audio/akode-plugins-mpeg/pkg-plist 1969-12-31 19:00:00.000000000 -0500
@@ -1,3 +0,0 @@
-lib/libakode_mpeg_decoder.a
-lib/libakode_mpeg_decoder.la
-lib/libakode_mpeg_decoder.so
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912180240.nBI2eMRI038290>