Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 May 2005 09:17:05 +0100 (BST)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        Scott Long <scottl@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/dev/random probe.c src/sys/opencrypto  deflate.c
Message-ID:  <20050530091556.A52379@fledge.watson.org>
In-Reply-To: <200505300501.j4U51ikj070065@repoman.freebsd.org>
References:  <200505300501.j4U51ikj070065@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Mon, 30 May 2005, Scott Long wrote:

>  malloc.h relies on param.h for a definition of MAXCPU.  I guess that there is
>  other header pollution that makes this work right now, but it falls over when
>  doing a RELENG_5 -> HEAD upgrade.

Odd -- I added a nested include of param.h from malloc.h to catch this. 
While almost certainly a bad idea (your fix is better), if you had the 
latest revision of malloc.h, it shouldn't have broken the build...  Was 
your malloc.h slightly stale, or is there more to it than that?

I'll basck out my change to malloc.h now that the dependencies are fixed. 
Thanks!

Robert N M Watson



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050530091556.A52379>