From owner-svn-ports-all@freebsd.org  Sat Oct 24 15:10:08 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 750FDA1D7C9
 for <svn-ports-all@mailman.ysv.freebsd.org>;
 Sat, 24 Oct 2015 15:10:08 +0000 (UTC) (envelope-from kris@pcbsd.org)
Received: from barracuda.ixsystems.com (mail.ixsystems.com [69.198.165.135])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "*.ixsystems.com",
 Issuer "Go Daddy Secure Certificate Authority - G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 080837E0
 for <svn-ports-all@freebsd.org>; Sat, 24 Oct 2015 15:10:06 +0000 (UTC)
 (envelope-from kris@pcbsd.org)
X-ASG-Debug-ID: 1445699404-08ca040e8504370002-Ooj6kR
Received: from [192.168.0.51] (75-130-56-30.static.kgpt.tn.charter.com
 [75.130.56.30]) by barracuda.ixsystems.com with ESMTP id sEyruVajXYmleugR
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO);
 Sat, 24 Oct 2015 08:10:05 -0700 (PDT)
X-Barracuda-Envelope-From: kris@pcbsd.org
X-Barracuda-AUTH-User: kris@pcbsd.org
X-Barracuda-Apparent-Source-IP: 75.130.56.30
X-ASG-Whitelist: Client
Subject: Re: svn commit: r400121 - head/net-im/teamwords
To: Alexey Dokuchaev <danfe@FreeBSD.org>, Kris Moore <kmoore@FreeBSD.org>
X-ASG-Orig-Subj: Re: svn commit: r400121 - head/net-im/teamwords
References: <201510241406.t9OE6uXi043030@repo.freebsd.org>
 <20151024142932.GB69999@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
From: Kris Moore <kris@pcbsd.org>
X-Enigmail-Draft-Status: N1110
Message-ID: <562B9F65.4010603@pcbsd.org>
Date: Sat, 24 Oct 2015 11:10:29 -0400
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101
 Thunderbird/38.3.0
MIME-Version: 1.0
In-Reply-To: <20151024142932.GB69999@FreeBSD.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Barracuda-Connect: 75-130-56-30.static.kgpt.tn.charter.com[75.130.56.30]
X-Barracuda-Start-Time: 1445699404
X-Barracuda-Encrypted: ECDHE-RSA-AES128-GCM-SHA256
X-Barracuda-URL: https://10.2.0.41:443/cgi-mod/mark.cgi
X-Virus-Scanned: by bsmtpd at ixsystems.com
X-Barracuda-BRTS-Status: 1
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Oct 2015 15:10:08 -0000

On 10/24/2015 10:29, Alexey Dokuchaev wrote:
> On Sat, Oct 24, 2015 at 02:06:56PM +0000, Kris Moore wrote:
>> New Revision: 400121
>> URL: https://svnweb.freebsd.org/changeset/ports/400121
>>
>> [...]
>> -.include <bsd.port.options.mk>
>> -
>>  do-install:
>>  	${STRIP_CMD} ${WRKSRC}/teamwords
>>  	${INSTALL} ${WRKSRC}/teamwords ${STAGEDIR}${PREFIX}/bin
> Wait, what?  You strip the binary first and then install it?  Why not
> use ${INSTALL_PROGRAM} which DTRT itself?
>
> ./danfe
>

It's what was suggested when I built the port with DEVELOPER=yes. Is the
end-result the same or is this just for the sake of minimalism? That
being said, I've changed it now.

-- 
Kris Moore
PC-BSD Software / iXsystems
Enterprise Storage & Servers Driven By Open Source