From owner-svn-ports-head@FreeBSD.ORG Mon Apr 21 14:17:22 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A56213DD for ; Mon, 21 Apr 2014 14:17:22 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3FD971B23 for ; Mon, 21 Apr 2014 14:17:22 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s3LEHMJV049973 for ; Mon, 21 Apr 2014 14:17:22 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.8/8.14.8/Submit) id s3LEHMhY049972 for svn-ports-head@freebsd.org; Mon, 21 Apr 2014 14:17:22 GMT (envelope-from bdrewery) Received: (qmail 64241 invoked from network); 21 Apr 2014 09:17:18 -0500 Received: from unknown (HELO roundcube.xk42.net) (10.10.5.5) by sweb.xzibition.com with SMTP; 21 Apr 2014 09:17:18 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 21 Apr 2014 09:17:17 -0500 From: Bryan Drewery To: Alexey Dokuchaev Subject: Re: Commit logs for 2014/04/11 Organization: FreeBSD In-Reply-To: <20140421100736.GA96588@FreeBSD.org> References: <20140412035900.3C695121E45@apnoea.adamw.org> <20140420092922.GA90642@FreeBSD.org> <20140421100736.GA96588@FreeBSD.org> Message-ID: X-Sender: bdrewery@FreeBSD.org User-Agent: Roundcube Webmail/0.9.5 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Apr 2014 14:17:22 -0000 On 2014-04-21 05:07, Alexey Dokuchaev wrote: > On Sun, Apr 20, 2014 at 02:35:25PM -0500, Bryan Drewery wrote: >> > On Apr 20, 2014, at 4:29, Alexey Dokuchaev wrote: >> >> On Sat, Apr 12, 2014 at 10:11:44AM -0400, Adam Weinberger wrote: >> >> * Please, please don't mandate .sample. Plenty of of ports install >> > >> > Actually, it's not really ".sample". It's any six-letter word if I read the >> > code correctly. >> >> No. It is literally only .sample. > > Right; I forgot to check the other file, sample.yaml. > >> >> sample conf files with different extension. "-dist" is very common >> >> for php ports, for example. Let @sample take two arguments. Like >> >> @sample etc/pants.conf-dist pants.conf >> > >> > Why do we need the second argument? Can't we just use the rightmost >> > extension? Proof of concept attached. >> >> I would think you would support consistency :) > > Well, at first it seemed like a nice idea that could be implemented > without > sacrificing much consistency. After received feedback, I'm no longer > sure > about it, so I guess I'm fine with ".sample", at least for the time > being. > > ./danfe It's a tough decision. It's not exactly simple to support an arbitrary extension. Pkg does not support arguments for Keywords. Some extensions are -dist. Which should have precedence over a file having both '.' and '-'? What if they have neither? My original PoC had support for -dist and .sample, but discussing with bapt we decided on making an implicit policy of files being installed as .sample. It's nicer for users if all sample/dist/original files are named the same. I'm still in favor of supporting '-dist' as well. -- Regards, Bryan Drewery