Date: Mon, 1 Oct 2012 17:57:38 GMT From: Miklos Magyari <magyarimiki@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/172216: mail/altermime fails to build using clang Message-ID: <201210011757.q91Hvcgu035616@red.freebsd.org> Resent-Message-ID: <201210011800.q91I0C3V004067@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 172216
>Category: ports
>Synopsis: mail/altermime fails to build using clang
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 01 18:00:12 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Miklos Magyari
>Release: 9.0-RELEASE
>Organization:
>Environment:
FreeBSD mira 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64
>Description:
mail/altermime fails to build using clang:
[...snip...]
===> Building for altermime-0.3.11.a1
clang -Wall -Werror -g -I. -O2 -c strstack.c
clang -Wall -Werror -g -I. -O2 -c mime_alter.c
clang -Wall -Werror -g -I. -O2 -c ffget.c
ffget.c:553:20: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality]
if ( (*crlfpos == '\r') )
~~~~~~~~~^~~~~~~
ffget.c:553:20: note: remove extraneous parentheses around the comparison to silence this warning
if ( (*crlfpos == '\r') )
~ ^ ~
ffget.c:553:20: note: use '=' to turn this equality comparison into an assignment
if ( (*crlfpos == '\r') )
^~
=
1 error generated.
*** [ffget.o] Error code 1
Stop in /usr/ports/mail/altermime/work/altermime-0.3.11.a1.
*** [do-build] Error code 1
Stop in /usr/ports/mail/altermime.
*** [/usr/ports/mail/altermime/work/.build_done.altermime._usr_local] Error code 1
Stop in /usr/ports/mail/altermime.
>How-To-Repeat:
# cd /usr/ports/mail/altermime
# make
>Fix:
A source patch under files/
# cat files/patch-::ffget.c
--- ffget.c.orig 2012-10-01 19:45:30.000000000 +0200
+++ ffget.c 2012-10-01 19:45:51.000000000 +0200
@@ -550,7 +550,7 @@
// if we have another \r after it, in which case, we
// turn on SINGLE_DELIMETER_MODE.
- if ( (*crlfpos == '\r') )
+ if ( *crlfpos == '\r' )
{
f->linebreak = FFGET_LINEBREAK_CR;
snprintf(f->lastbreak,sizeof(f->lastbreak),"\r");
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210011757.q91Hvcgu035616>