From owner-freebsd-net Sat Dec 16 12: 0:57 2000 From owner-freebsd-net@FreeBSD.ORG Sat Dec 16 12:00:55 2000 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from prism.flugsvamp.com (cb58709-a.mdsn1.wi.home.com [24.17.241.9]) by hub.freebsd.org (Postfix) with ESMTP id 3422A37B400 for ; Sat, 16 Dec 2000 12:00:55 -0800 (PST) Received: (from jlemon@localhost) by prism.flugsvamp.com (8.11.0/8.11.0) id eBGJutE75992; Sat, 16 Dec 2000 13:56:55 -0600 (CST) (envelope-from jlemon) Date: Sat, 16 Dec 2000 13:56:55 -0600 From: Jonathan Lemon To: "Louis A. Mamakos" Cc: Jonathan Lemon , bmilekic@technokratis.com, net@FreeBSD.ORG Subject: Re: Changing the names of some M_flags Message-ID: <20001216135655.L89463@prism.flugsvamp.com> References: <200012161934.eBGJYdj75335@prism.flugsvamp.com> <200012161945.eBGJjh507797@whizzo.transsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0pre2i In-Reply-To: <200012161945.eBGJjh507797@whizzo.transsys.com> Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sat, Dec 16, 2000 at 02:45:43PM -0500, Louis A. Mamakos wrote: > > In article you write: > > > > > >On Sat, 16 Dec 2000, Alfred Perlstein wrote: > > > > > >> I think M_DONTWAIT is fine as it was, and M_TRYWAIT instead of M_TRY_WAIT. > > >> > > >> Leaving it as M_DONTWAIT should reduce the delta by quite a bit and > > >> M_TRYWAIT vs M_TRY_WAIT because you have M_DONTWAIT/M_DONTBLOCK. > > >> > > >> -Alfred > > > > > > I agree. Anyone else before I re-roll? :-) > > > > I second Alfred's suggestion. > > Is this just going to make portablity between the various *BSD kernels > more difficult for what's essentially a cosmetic change? I'm thinking > of things like KAME, ALTQ, etc. Well, as it is a change in semantics, it does help to catch problems in porting. AFAIK, NetBSD (and probably Open) do not allow m_get() to return NULL in the M_WAIT case, so the underlying code will have to be changed in order to handle this difference anyway. -- Jonathan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message