Date: Wed, 15 Nov 1995 00:15:21 -0800 From: David Greenman <davidg@Root.COM> To: Bruce Evans <bde@zeta.org.au> Cc: peter@haywire.dialix.com, freebsd-hackers@freebsd.org Subject: Re: Can't NFS mount with latest -current Message-ID: <199511150815.AAA00161@corbin.Root.COM> In-Reply-To: Your message of "Wed, 15 Nov 95 19:06:56 %2B1100." <199511150806.TAA25412@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
>>>Anyway, Poul-Henning has created two sysctl types.. one is a >>>null-terminated "C-style" string, and the other is an "opaque" chunk >>>of byte counted memory. IMHO, the string version should always return >>>the correct amount of characters that the string actually uses. If >>>the whole block is to be returned, that's what the opaque type is for. > >> Yes, the "size" argument should be used to limit the copy, not prevent it >>from happening. We should be using copyoutstr() for this. > >We shouldn't be using copyoutstr() for this. ... >copyoutstr() is the most complicated routine in support.s, but is >currently unused. Are you saying that you would like to officially remove support for copyoutstr() in favor of strlen/copyout? I can agree with that. BTW, we should remove the #if 0'd crap in cpufunc.h: #if 0 /* * These functions in support.s are declared elsewhere. */ ... -DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511150815.AAA00161>