Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 14 Dec 2012 08:53:25 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r244205 - stable/8/sys/kern
Message-ID:  <201212140853.qBE8rPHm027016@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Fri Dec 14 08:53:25 2012
New Revision: 244205
URL: http://svnweb.freebsd.org/changeset/base/244205

Log:
  MRC r243021:
  
  return ERANGE if the buffer is too small to contain the login as documented in
  the manpage
  
  Reviewed by:	cognet, kib

Modified:
  stable/8/sys/kern/kern_prot.c
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/kern/   (props changed)

Modified: stable/8/sys/kern/kern_prot.c
==============================================================================
--- stable/8/sys/kern/kern_prot.c	Fri Dec 14 08:52:08 2012	(r244204)
+++ stable/8/sys/kern/kern_prot.c	Fri Dec 14 08:53:25 2012	(r244205)
@@ -2065,6 +2065,8 @@ getlogin(struct thread *td, struct getlo
 	bcopy(p->p_session->s_login, login, uap->namelen);
 	SESS_UNLOCK(p->p_session);
 	PROC_UNLOCK(p);
+	if (strlen(login) + 1 > uap->namelen)
+		return (ERANGE);
 	error = copyout(login, uap->namebuf, uap->namelen);
 	return (error);
 }



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201212140853.qBE8rPHm027016>