From owner-cvs-all@FreeBSD.ORG  Mon Jan  4 20:46:17 2010
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 93E2C106568B
	for <cvs-all@FreeBSD.org>; Mon,  4 Jan 2010 20:46:17 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id 3CCAF8FC19
	for <cvs-all@FreeBSD.org>; Mon,  4 Jan 2010 20:46:16 +0000 (UTC)
Received: (qmail 26610 invoked by uid 399); 4 Jan 2010 20:46:15 -0000
Received: from localhost (HELO foreign.dougb.net)
	(dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 4 Jan 2010 20:46:15 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4B42539A.4050007@FreeBSD.org>
Date: Mon, 04 Jan 2010 12:46:18 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://SupersetSolutions.com/
User-Agent: Thunderbird 2.0.0.23 (X11/20091206)
MIME-Version: 1.0
To: "Philip M. Gollucci" <pgollucci@FreeBSD.org>
References: <201001040434.o044Y7Uv096701@repoman.freebsd.org>
In-Reply-To: <201001040434.o044Y7Uv096701@repoman.freebsd.org>
X-Enigmail-Version: 0.96.0
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Danil <desruptorrogue@gmail.com>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/ftp/proftpd Makefile ports/ftp/proftpd/files
 proftpd.in proftpd.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Jan 2010 20:46:17 -0000

This is an interesting idea, one I may just steal for rc.d/named. :)

Couple of things ... first the new line has /usr/local hard-coded, it
should be %%PREFIX%%. Second, is it ever possible that proftpd will
start up without the PidFile line in the conf? If so, then there
should probably be a default setting, error checking on the pidfile
value, or both.

Also the usual note about REQUIRE: DAEMON + BEFORE: LOGIN should
probably be replaced with REQUIRE: LOGIN unless there is a good reason
to start it earlier.


hth,

Doug


Philip M. Gollucci wrote:
> pgollucci    2010-01-04 04:34:07 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     ftp/proftpd          Makefile 
>   Added files:
>     ftp/proftpd/files    proftpd.in 
>   Removed files:
>     ftp/proftpd/files    proftpd.sh.in 
>   Log:
>   - Pull the pidfile path from a central location (the config file)
>     instead of hard coding it again in the rc.d script
>   
>   PR:             ports/141945  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=141945
>   Submitted by:   Danil <desruptorrogue@gmail.com>
>   
>   Revision  Changes    Path
>   1.166     +2 -1      ports/ftp/proftpd/Makefile
>   1.1       +43 -0     ports/ftp/proftpd/files/proftpd.in (new)
>   1.5       +0 -43     ports/ftp/proftpd/files/proftpd.sh.in (dead)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/Makefile.diff?&r1=1.165&r2=1.166&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/files/proftpd.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/ftp/proftpd/files/proftpd.sh.in
> 


-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

	Computers are useless. They can only give you answers.
			-- Pablo Picasso