From owner-freebsd-wireless@FreeBSD.ORG Sat Mar 15 23:31:45 2014 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id BBF80968; Sat, 15 Mar 2014 23:31:45 +0000 (UTC) Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com [IPv6:2607:f8b0:400d:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 53B2C1A1; Sat, 15 Mar 2014 23:31:45 +0000 (UTC) Received: by mail-qc0-f174.google.com with SMTP id x13so4420619qcv.5 for ; Sat, 15 Mar 2014 16:31:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2P8LPp0Z8Luy6lDYYVSpOczt/e+mmxCSxbKoGkaix5I=; b=Dcadoq29xIF2lGMCuoeJ5QzIxNMI2uLNKC/h1h1rkcfgQHYx9VmvFfrBw6qXAgm6zB FzzVZx4w9aqE/PiDPbJDPsMMJPgCu3+aJF0YJQogDcHk5ToyFpURz2lfhhvnBQJAUmUX sX5vspFLOZFy/DnNiAWUXKnRIohcxWVJo0QHemHYtsLJi80rupHJm143BijwSBfHOyvS wffhFQDPciiznRW6IDgdGeZqCeRp1s/3iKOKt3NfJPb/Lq9reS6121UHtER1SJLHbq+m PU6GjJqRiUcvweErdfDV3QVID8KPwTv+aZHylXnh9Ms5mUwKvWmWRYoHQPMNALK6ox2b jIVw== MIME-Version: 1.0 X-Received: by 10.229.89.65 with SMTP id d1mr19139193qcm.14.1394926304491; Sat, 15 Mar 2014 16:31:44 -0700 (PDT) Received: by 10.224.8.137 with HTTP; Sat, 15 Mar 2014 16:31:44 -0700 (PDT) In-Reply-To: References: Date: Sat, 15 Mar 2014 16:31:44 -0700 Message-ID: Subject: Re: iwn(4) and WEP From: Adrian Chadd To: sean bruno Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-wireless@freebsd.org" , Allan Jude X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Mar 2014 23:31:45 -0000 ... and can someone please file a bloody PR? :) -a On 15 March 2014 16:31, Adrian Chadd wrote: > Hm, from my understanding, the problem is this: > > * a bunch of drivers don't advertise that they do crypto stuff natively; > * net80211 however supports software encryption for other things; > * and what we're doing is somehow passing those caps all the way down > to the supplicant; > * .. that believes that it's not supported. > > Now, I _think_ that maybe we should be teaching net80211 to fill in > the capabilities for what it supports before kicking them up to the > supplicant layer, since it knows if there's hardware or softwrae > support for things. > > So, ok. i'll talk with jouni/rui and see if we can come up with a better fix. > > Thanks! > > > -a > > > On 15 March 2014 16:26, sean bruno wrote: >> Will do. Rui generated this, but it may be masking something else. >> >> http://people.freebsd.org/~rpaulo/wpa.patch >> >> >> -------- Original message -------- >> From: Adrian Chadd >> Date:03/16/2014 8:18 AM (GMT+09:00) >> To: Allan Jude >> Cc: freebsd-wireless@freebsd.org,Sean Bruno >> Subject: Re: iwn(4) and WEP >> >> Please commit the wpa patch! >> >> >> -a >> >> >> On 15 March 2014 02:43, Allan Jude wrote: >>> On 2014-03-15 13:46, Adrian Chadd wrote: >>> >>> Can you put this up on http or attach as .txt so I can read it in this >>> here >>> phone mail app? >>> >>> Adrian >>> >>> On Mar 14, 2014 9:41 PM, "Allan Jude" wrote: >>>> >>>> On 03/14/2014 22:52, Sean Bruno wrote: >>>> > It looks like the wpa_supplicant 2.0 import now checks the >>>> > cryptocapability mask when trying to validate WEP usage. >>>> > >>>> > iwn(4) does not populate the mask with any values so wpa_supplicant >>>> > sees >>>> > a value of 0. >>>> > >>>> > I added the capabilites and can associate, but dhclient cannot get an >>>> > IP >>>> > from the AP. I assume then, that once again, I don't know what I'm >>>> > doing. >>>> > >>>> > More or less, this is what I tried: >>>> > >>>> > Index: if_iwn.c >>>> > =================================================================== >>>> > --- if_iwn.c (revision 263173) >>>> > +++ if_iwn.c (working copy) >>>> > @@ -564,6 +564,8 @@ >>>> > | IEEE80211_C_PMGT /* Station-side power >>>> > mgmt >>>> > */ >>>> > ; >>>> > >>>> > + ic->ic_cryptocaps = IEEE80211_CRYPTO_WEP; >>>> > + >>>> > /* Read MAC address, channels, etc from EEPROM. */ >>>> > if ((error = iwn_read_eeprom(sc, macaddr)) != 0) { >>>> > device_printf(dev, "could not read EEPROM, error %d\n", >>>> > >>>> > >>>> > sean >>>> > >>>> > p.s. Allan Jude came up with a hack for wpa_supplicant that seems to >>>> > work, so I've bcc'd him here to get a patch out of him. >>>> >>>> Attached is my (horrible) patch that no one should use. But it is >>>> available for those of us at the conference who just need something that >>>> will work for the rest of the weekend. >>>> >>>> >>>> >>>> _______________________________________________ >>>> freebsd-wireless@freebsd.org mailing list >>>> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless >>>> To unsubscribe, send any mail to >>>> "freebsd-wireless-unsubscribe@freebsd.org" >>> >>> >>> Here is the web url for my patch (which no one should use): >>> http://www.allanjude.com/bsd/wpa_supplicant.wep.patch >>> >>> Here is the patch rpaulo sent us on IRC: >>> http://people.freebsd.org/~rpaulo/wpa.patch >>> >>>