From owner-svn-src-all@FreeBSD.ORG  Sun Dec 18 02:17:12 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5AC72106564A
	for <svn-src-all@freebsd.org>; Sun, 18 Dec 2011 02:17:12 +0000 (UTC)
	(envelope-from joerg@britannica.bec.de)
Received: from mo-p00-ob6.rzone.de (mo-p00-ob6.rzone.de
	[IPv6:2a01:238:20a:202:53f0::1])
	by mx1.freebsd.org (Postfix) with ESMTP id E9E6C8FC17
	for <svn-src-all@freebsd.org>; Sun, 18 Dec 2011 02:17:11 +0000 (UTC)
X-RZG-AUTH: :JiIXek6mfvEEUpFQdo7Fj1/zg48CFjWjQv0cW+St/nW/afgnrylsiW+xbjV+pgEJ
X-RZG-CLASS-ID: mo00
Received: from britannica.bec.de
	(ip-109-45-171-208.web.vodafone.de [109.45.171.208])
	by smtp.strato.de (fruni mo31) (RZmta 26.15 DYNA|AUTH)
	with (DHE-RSA-AES128-SHA encrypted) ESMTPA id e040a3nBHMYW4v
	for <svn-src-all@freebsd.org>; Sun, 18 Dec 2011 03:16:45 +0100 (MET)
Received: by britannica.bec.de (sSMTP sendmail emulation);
	Sun, 18 Dec 2011 03:16:40 +0100
Date: Sun, 18 Dec 2011 03:16:40 +0100
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: svn-src-all@freebsd.org
Message-ID: <20111218021640.GA2436@britannica.bec.de>
References: <201112171721.pBHHLloU069166@svn.freebsd.org>
	<4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4C98B8D8-99F6-4996-A0FB-C128D9384180@lists.zabbadoz.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: svn commit: r228650 - head/usr.bin/netstat
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Dec 2011 02:17:12 -0000

On Sat, Dec 17, 2011 at 09:53:56PM +0000, Bjoern A. Zeeb wrote:
> 
> On 17. Dec 2011, at 17:21 , Dimitry Andric wrote:
> 
> > Author: dim
> > Date: Sat Dec 17 17:21:47 2011
> > New Revision: 228650
> > URL: http://svn.freebsd.org/changeset/base/228650
> > 
> > Log:
> >  In usr.bin/netstat/atalk.c, work around a clang false positive with
> >  printf format warnings and conditional operators.
> > 
> 
> This does not sound like a good idea.  Make clang work.

Strictly speaking, clang is correct here. While the 'h' modifier is
effectively a nop due to integer promotion rules, the intention is
clearly "I am going to use a unsigned short here". Of course, the bug in
the change is that it is using short...

Joerg