Date: Wed, 28 Aug 2002 07:55:27 -0700 From: "Moore, Robert" <robert.moore@intel.com> To: "'acpi-jp@jp.FreeBSD.org'" <acpi-jp@jp.FreeBSD.org>, yb@sainte-barbe.org Cc: current@freebsd.org Subject: RE: [acpi-jp 1759] Re: Call for testers: acpica-unix-20020815 Message-ID: <B9ECACBD6885D5119ADC00508B68C1EA0D19B721@orsmsx107.jf.intel.com>
next in thread | raw e-mail | index | archive | help
Your patches seem to fix three things:
1) Implicit returns
2) Invalid escape sequences (missing double backslashes)
3) Uninitialized Locals
Which one was causing the original problem as reported?
Thanks,
Bob
-----Original Message-----
From: Mitsuru IWASAKI [mailto:iwasaki@jp.FreeBSD.org]
Sent: Wednesday, August 28, 2002 3:36 AM
To: yb@sainte-barbe.org; acpi-jp@jp.FreeBSD.org
Cc: current@freebsd.org
Subject: [acpi-jp 1759] Re: Call for testers: acpica-unix-20020815
> 1) Fix the ASL so that it compiles without errors or warnings
> 2) Override the BIOS version of the table with your new one. (I don't
know
> how this is done on FreeBSD, someone else will have to help you.
Attached patches will fix the ASL.
For compiling and overriding, please refer to acpi(4).
# iasl Tecra8200.asl
# cp acpi_dsdt.aml /boot/
# echo 'acpi_dsdt_load="YES"' >> /boot/loader.conf
Thanks
--- Tecra8200.asl- Wed Aug 28 19:30:30 2002
+++ Tecra8200.asl Wed Aug 28 19:26:57 2002
@@ -79,11 +79,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x1)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQA)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQA))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQA)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQA))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQA, Local0)
@@ -108,11 +108,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x2)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQB)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQB))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQB)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQB))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQB, Local0)
@@ -137,11 +137,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x3)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQC)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQC))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQC)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQC))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQC, Local0)
@@ -166,11 +166,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x4)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQD)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQD))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQD)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQD))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQD, Local0)
@@ -195,11 +195,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x5)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQE)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQE))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQE)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQE))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQE, Local0)
@@ -224,11 +224,11 @@
Name(_HID, 0x0f0cd041)
Name(_UID, 0x8)
Method(_STA) {
- STAL(\_SB_.PCI0.FNC0.IRQH)
+ Return(STAL(\_SB_.PCI0.FNC0.IRQH))
}
Name(_PRS, Buffer(0x6) {0x23, 0xf8, 0x1c, 0x18, 0x79, 0x0 })
Method(_CRS) {
- CRSL(\_SB_.PCI0.FNC0.IRQH)
+ Return(CRSL(\_SB_.PCI0.FNC0.IRQH))
}
Method(_DIS) {
Store(\_SB_.PCI0.FNC0.IRQH, Local0)
@@ -253,7 +253,7 @@
Name(_HID, 0x010cd041)
Name(_STA, 0xf)
Method(_CRS) {
- CRS_(0x1)
+ Return(CRS_(0x1))
}
OperationRegion(SRAM, SystemMemory, 0x000ee800, 0x1800)
Field(SRAM, AnyAcc, NoLock, Preserve) {
@@ -944,13 +944,13 @@
Name(_HID, 0x000ed041)
Name(_UID, 0x2)
Method(_STA) {
- STA_(0x25)
+ Return(STA_(0x25))
}
Method(_CRS) {
- CRS_(0x25)
+ Return(CRS_(0x25))
}
Method(_PRS) {
- PRS_(0x25)
+ Return(PRS_(0x25))
}
Method(_SRS, 1) {
SRS_(0x25, Arg0)
@@ -965,7 +965,7 @@
PS3_(0x25)
}
Method(_PSC) {
- PSC_(0x25)
+ Return(PSC_(0x25))
}
Name(_PRW, Package(0x2) {
0xb,
@@ -982,7 +982,7 @@
Device(VDSC) {
Name(_HID, 0x1001a865)
Method(_STA) {
- STA_(0x26)
+ Return(STA_(0x26))
}
}
PowerResource(PDOC, 1, 0) {
@@ -1006,7 +1006,7 @@
Event(DKSQ)
Device(DLAN) {
Name(_ADR, 0x000a0000)
- Name(_EJD, "\_SB_.PCI0.PCIB.DOCK")
+ Name(_EJD, "_SB_.PCI0.PCIB.DOCK")
Method(_PS0, 0, Serialized) {
Store(\_SB_.PCI0.PCIB.BRGB, Local0)
ShiftLeft(Local0, 0x8, Local0)
@@ -1064,7 +1064,7 @@
Offset(0x19),
FBRG, 8
}
- Name(_EJD, "\_SB_.PCI0.PCIB.DOCK")
+ Name(_EJD, "_SB_.PCI0.PCIB.DOCK")
Name(_PRT, Package(0x9) {
Package(0x4) {
0x0003ffff,
@@ -1213,6 +1213,7 @@
ShiftLeft(Local0, 0x18, Local0)
Or(Local0, 0x0018b10b, Local0)
Store(0x53, \_SB_.MEM_.IEDI)
+ Store(0x0, Local4)
SMBR(0xfe00, Local4, 0x0, 0x0, 0xb2)
Store(\_SB_.MEM_.OECX, Local0)
Store(0x52, \_SB_.MEM_.IEDI)
@@ -1290,6 +1291,7 @@
ShiftLeft(Local0, 0x18, Local0)
Or(Local0, 0x0018b10b, Local0)
Store(0x53, \_SB_.MEM_.IEDI)
+ Store(0x0, Local4)
SMBR(0xfe00, Local4, 0x0, 0x0, 0xb2)
Store(\_SB_.MEM_.OECX, Local0)
Store(0x52, \_SB_.MEM_.IEDI)
@@ -1441,6 +1443,7 @@
ShiftLeft(Local0, 0x18, Local0)
Or(Local0, 0x0018b10b, Local0)
Store(0x55, \_SB_.MEM_.IEDI)
+ Store(0x0, Local4)
SMBR(0xfe00, Local4, 0x0, 0x0, 0xb2)
Store(\_SB_.MEM_.OECX, Local0)
Store(0x52, \_SB_.MEM_.IEDI)
@@ -1518,6 +1521,7 @@
ShiftLeft(Local0, 0x18, Local0)
Or(Local0, 0x0018b10b, Local0)
Store(0x55, \_SB_.MEM_.IEDI)
+ Store(0x0, Local4)
SMBR(0xfe00, Local4, 0x0, 0x0, 0xb2)
Store(\_SB_.MEM_.OECX, Local0)
Store(0x52, \_SB_.MEM_.IEDI)
@@ -1584,7 +1588,7 @@
Device(NOV0) {
Name(_ADR, 0x000b0000)
Name(_SUN, 0x2)
- Name(_EJD, "\_SB_.PCI0.PCIB.DOCK")
+ Name(_EJD, "_SB_.PCI0.PCIB.DOCK")
Name(_PRW, Package(0x2) {
0xb,
0x3,
@@ -1650,7 +1654,7 @@
PS3_(0x7)
}
Method(_PSC) {
- PSC_(0x7)
+ Return(PSC_(0x7))
}
}
Device(PS2M) {
@@ -1685,13 +1689,13 @@
Device(FDD_) {
Name(_HID, 0x0007d041)
Method(_STA) {
- STA_(0xb)
+ Return(STA_(0xb))
}
Method(_CRS) {
- CRS_(0xb)
+ Return(CRS_(0xb))
}
Method(_PRS) {
- PRS_(0xb)
+ Return(PRS_(0xb))
}
Method(_SRS, 1) {
SRS_(0xb, Arg0)
@@ -1706,19 +1710,19 @@
PS3_(0xb)
}
Method(_PSC) {
- PSC_(0xb)
+ Return(PSC_(0xb))
}
}
Device(COM_) {
Name(_HID, 0x0105d041)
Method(_STA) {
- STA_(0xe)
+ Return(STA_(0xe))
}
Method(_CRS) {
- CRS_(0xe)
+ Return(CRS_(0xe))
}
Method(_PRS) {
- PRS_(0xe)
+ Return(PRS_(0xe))
}
Method(_SRS, 1) {
SRS_(0xe, Arg0)
@@ -1733,7 +1737,7 @@
PS3_(0xe)
}
Method(_PSC) {
- PSC_(0xe)
+ Return(PSC_(0xe))
}
Name(_PRW, Package(0x2) {
0xb,
@@ -1746,13 +1750,13 @@
Device(FSIR) {
Name(_HID, 0x10f0a34d)
Method(_STA) {
- STA_(0xf)
+ Return(STA_(0xf))
}
Method(_CRS) {
- CRS_(0xf)
+ Return(CRS_(0xf))
}
Method(_PRS) {
- PRS_(0xf)
+ Return(PRS_(0xf))
}
Method(_SRS, 1) {
SRS_(0xf, Arg0)
@@ -1767,19 +1771,19 @@
PS3_(0xf)
}
Method(_PSC) {
- PSC_(0xf)
+ Return(PSC_(0xf))
}
}
Device(PRT_) {
Name(_HID, 0x0104d041)
Method(_STA) {
- STA_(0x10)
+ Return(STA_(0x10))
}
Method(_CRS) {
- CRS_(0x10)
+ Return(CRS_(0x10))
}
Method(_PRS) {
- PRS_(0x10)
+ Return(PRS_(0x10))
}
Method(_SRS, 1) {
SRS_(0x10, Arg0)
@@ -1791,13 +1795,13 @@
Device(PRT1) {
Name(_HID, 0x0004d041)
Method(_STA) {
- STA_(0x12)
+ Return(STA_(0x12))
}
Method(_CRS) {
- CRS_(0x12)
+ Return(CRS_(0x12))
}
Method(_PRS) {
- PRS_(0x12)
+ Return(PRS_(0x12))
}
Method(_SRS, 1) {
SRS_(0x12, Arg0)
@@ -1810,13 +1814,13 @@
Name(_HID, 0x000ed041)
Name(_UID, 0x1)
Method(_STA) {
- STA_(0x13)
+ Return(STA_(0x13))
}
Method(_CRS) {
- CRS_(0x13)
+ Return(CRS_(0x13))
}
Method(_PRS) {
- PRS_(0x13)
+ Return(PRS_(0x13))
}
Method(_SRS, 1) {
SRS_(0x13, Arg0)
@@ -1831,7 +1835,7 @@
PS3_(0x13)
}
Method(_PSC) {
- PSC_(0x13)
+ Return(PSC_(0x13))
}
Name(_PRW, Package(0x2) {
0xb,
@@ -2369,7 +2373,7 @@
Name(_ADR, 0x001f0002)
Device(HUB1) {
Name(_ADR, 0x0)
- Name(_EJD, "\_SB_.PCI0.PCIB.DOCK")
+ Name(_EJD, "_SB_.PCI0.PCIB.DOCK")
Device(POT1) {
Name(_ADR, 0x1)
}
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B9ECACBD6885D5119ADC00508B68C1EA0D19B721>