Date: Fri, 5 May 2017 12:46:14 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Franco Fichtner <franco@lastsummer.de>, FreeBSD Mailing List <freebsd-ports@freebsd.org>, Aristedes Maniatis <ari@ish.com.au> Subject: Re: diff and submissions Message-ID: <ace64882-35ab-e8fd-3c07-844567082edd@FreeBSD.org> In-Reply-To: <20170505103745.sa4oeq573szssqn4@ivaldir.net> References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> <20170505102006.5lzf6kt7rotzvzeg@ivaldir.net> <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org> <20170505103745.sa4oeq573szssqn4@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8kr5Pq1gWhURR6BNb9HN1cpU7MoLFrDrQ Content-Type: multipart/mixed; boundary="AnwlDNLH8Vu38eMdXQar6VuDTxcg95kUo"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: Franco Fichtner <franco@lastsummer.de>, FreeBSD Mailing List <freebsd-ports@freebsd.org>, Aristedes Maniatis <ari@ish.com.au> Message-ID: <ace64882-35ab-e8fd-3c07-844567082edd@FreeBSD.org> Subject: Re: diff and submissions References: <750748ab-0e0e-cbb2-0b3b-d236829ee958@ish.com.au> <063dd680-2600-b440-b06b-04323eed6e58@FreeBSD.org> <22B42BD4-B348-49F6-8CF6-82B7B00E6B84@lastsummer.de> <05fd8f53-30b8-88fb-4d70-68637b2261b1@FreeBSD.org> <20170505102006.5lzf6kt7rotzvzeg@ivaldir.net> <ed229c37-a2d0-8590-285f-640fae8539fb@FreeBSD.org> <20170505103745.sa4oeq573szssqn4@ivaldir.net> In-Reply-To: <20170505103745.sa4oeq573szssqn4@ivaldir.net> --AnwlDNLH8Vu38eMdXQar6VuDTxcg95kUo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 05/05/2017 =C3=A0 12:37, Baptiste Daroussin a =C3=A9crit : > On Fri, May 05, 2017 at 12:27:13PM +0200, Mathieu Arnold wrote: >> Le 05/05/2017 =C3=A0 12:20, Baptiste Daroussin a =C3=A9crit : >>> I made a script which is a few lines of shell that converts pull >>> requests to >>> phabricator reviews automatically. >>> >>> I have handed it to some of the phabricator admins, I hope it will be= progress >>> soon. >> Please, do not do that. >> >> Phabricator is for code review, not bug reports. It all ends up in ou= r >> repository, but Phabricator does not have any maintainer notification >> like Bugzilla has. >> robak@ has a script that does pull-request -> bugzilla, and it has bee= n >> waiting for months for someone with access to do something about it. >> > Pull request are for code submissions and phabricator is the equivalent= for that It is great to review code, yes, but it will not notify maintainers that they have a patch for one of their ports, it adds more work for the ports committers that will have to go and review the code, and maybe notice it came from github, and then maybe notice that someone need to notify the maintainer of the port in question, so that they can accept, or not, the patch. It is mostly going to end up having code review that are not handled by anyone because they are not code review, they came from github, and the submitter on github is not aware that there has been some review and they need to update their code, or that they need to submit it to bugzilla afterwards so that it gets reviewed by the maintainer. --=20 Mathieu Arnold --AnwlDNLH8Vu38eMdXQar6VuDTxcg95kUo-- --8kr5Pq1gWhURR6BNb9HN1cpU7MoLFrDrQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZDFf2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IK+UP/RFig/1enFtpjUDboeQwUC+K ugzEirksKlOt/5bSBqs4uInxfW40lb+bVvB/a9KD1LCzHNqZQhhs+4Rdig/zM2Dx Cy/4Ha+RaWVhnoQ2K5fRUbYOpj0JlYHfu9x4stG/VbYtdDQRafUVcqUXQLviSyti al09JTN3tH7jILBpU1aYpJiJ+k5JwsHZQQGcOOw6ytCNZzDQsaoNsydXC4FtEUqt ABCSf4f1owUoI879CSh83CAP/OxEKVeBYjzoYe6dhvihjEa7HbcV9dstdfwycKMW xMJZwr3XUWqUfjZvnmDNw0Pj+veaQD7yMRawxv9sqqUCE0WZYSHKEZwUb4B8U2cy ON5Mjc/bC+CTeI87r1r0/Uh1yuRwg8aOTYDk/4CyNSfUr+CZOTgHCoK92bSQ0ny3 lTarQ8VedO+O9QCrdC9REFnuTs51FG9vu6gVNZB8+renD9doju8R4rh5TW0DXZnI rQVIFsoM/BVhjKQtINd9GkQfSHfw6v7U+0lQxFGxRG4SXOuA4XQ0EwoAGDlc3tvv ni+FdaAzPr76m8woVDUB7YgPg1x/WdVn9HXuCaYReMpi1QWImmF2LuDC/KWQX5Or fjuzwxKFXor20id8PedLsrq5x7UmIcPlj4BrKVZhihmpE3rFHB5NLGX1d0dyqf/r p/4xCfUdR9v1Gc5q0XoX =c935 -----END PGP SIGNATURE----- --8kr5Pq1gWhURR6BNb9HN1cpU7MoLFrDrQ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ace64882-35ab-e8fd-3c07-844567082edd>