Date: Sat, 17 Oct 2015 23:36:53 +0200 From: Jan Beich <jbeich@vfemail.net> To: Kurt Jaeger <pi@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399543 - in head/net: . openbsc openbsc/files Message-ID: <bnbx-41oq-wny@vfemail.net> In-Reply-To: <201510171655.t9HGtWH0004537@repo.freebsd.org> (Kurt Jaeger's message of "Sat, 17 Oct 2015 16:55:32 %2B0000 (UTC)") References: <201510171655.t9HGtWH0004537@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Kurt Jaeger <pi@FreeBSD.org> writes:
> +USES=3D autoreconf compiler:c11 gmake pkgconfig
USES=3Dautoreconf often wants INSTALL_TARGET=3Dinstall-strip which is a
standard automake target.
> +GNU_CONFIGURE=3Dyes
Missing indentation between =3D and the value?
> +AUTOMAKE_ARGS=3D --gnu --add-missing --copy
USE_AUTOTOOLS vestige?
> +CONFIGURE_ARGS+=3D CFLAGS=3D"-I${LOCALBASE}/include"
This overrides local CFLAGS, even defaults provided by sys.mk.
Ironically, ports-mgmt/portlint only complains about _ENV not _ARGS but
the rationale applies to both.
WARN: Makefile: CFLAGS/CXXFLAGS are not needed in CONFIGURE_ENV as they a=
re already added there in bsd.port.mk.
WARN: Makefile: Consider passing include paths to configure via the CPPFL=
AGS macro (i.e. CPPFLAGS+=3D-I...)
FATAL: Makefile: CFLAGS are clobbered in CONFIGURE_ENV. Alter CFLAGS in =
the Makefile with CFLAGS+=3D... instead
> +OPTIONS_DEFAULT=3D
Why empty?
> +SQLITE_LIB_DEPENDS=3D libsqlite.so:${PORTSDIR}/databases/sqlite3
How does one disable SQLITE if libsqlite3.so is already installed?
> +post-patch:
> + ${REINPLACE_CMD} -e 's|pkgconfigdir.*|pkgconfigdir =3D ${PREFIX}/libdat=
a/pkgconfig|g' \
> + ${WRKSRC}/Makefile.am
Why not the following?
USES =3D pathfix
PATHFIX_MAKEFILEIN =3D Makefile.am
> ++++ include/openbsc/mgcp.h
> +@@ -31,6 +31,11 @@
> +=20
> + #include <arpa/inet.h>
> +=20
> ++#ifdef __FreeBSD__
> ++#include <sys/socket.h>
> ++#include <netinet/in.h>
> ++#endif
Why include only *some* POSIX headers conditionally?
> ++++ include/openbsc/rtp.h
> +@@ -10,6 +10,12 @@
> + # define __BYTE_ORDER __DARWIN_BYTE_ORDER
> + # define __LITTLE_ENDIAN __DARWIN_LITTLE_ENDIAN
> + # define __BIG_ENDIAN __DARWIN_BIG_ENDIAN
> ++# elif defined(__FreeBSD__)
> ++# if __FreeBSD_version < 1000000
> ++# include <machine/endian.h>
> ++# else
> ++# include <x86/endian.h>
> ++# endif
These headers aren't supposed to be included directly, see byteorder(9).
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQF8BAEBCgBmBQJWIr92XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF
NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bnTEH/AmZMUcViZoXo/u/dQrI2GHD
dCPdrrka2xBkPdwnOMrChNVc8t+8nrhPPb3bJOu5RVFDKdjkXa/Wp4Si8IVLEWU7
aMCIRJdS7Xs0r98RKxAwQhnjG9jEK99oOYhV1qWOhHuHQTfR3z4Lor9/NKiSB+W0
tv6ylHarhyKBp3SJDnOxIMWFl3bgCx6ZEdGFer1OPLiDE6loQsSXIr4NVa7J9NqG
quxtBDjJaJ5v7HPm7NCsF3MCW7e92uA0zU4LB1GoliKK09KkSrpYjMvelPAdGsbN
b6/kYGikZHTJspqoeCMIDH9TRCCD4I/tnlTdv3tarWvIeRihhSdfzE3DHnJQ5vM=
=qYjV
-----END PGP SIGNATURE-----
--=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bnbx-41oq-wny>