From owner-svn-ports-head@FreeBSD.ORG Mon Feb 25 07:28:43 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D51FB56E; Mon, 25 Feb 2013 07:28:43 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x22d.google.com (ia-in-x022d.1e100.net [IPv6:2607:f8b0:4001:c02::22d]) by mx1.freebsd.org (Postfix) with ESMTP id 77429202; Mon, 25 Feb 2013 07:28:43 +0000 (UTC) Received: by mail-ia0-f173.google.com with SMTP id h37so2208598iak.18 for ; Sun, 24 Feb 2013 23:28:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=AKwTNxG6uYl3WujF6s5XXjzRVT5V6MrjSI1mjlJLajQ=; b=a0BcklK84ElzyeoXDn6LdrEo/QrDtz7OEsckHzC92kQFq8eC0UyTlB4u5AE1UXC6xW VbKiiLxlgf2oIZxZS+6PP8ajHt97MSg+YqBBlcaR4QAjyVIAPqZ/c0xa+f1s3qMQyafY zhEZ5vJMQvmvauWLj1zCgx6dwsChNizokEhEbdlealaOroB0f5O4jeFk5fgR9Uu1eWKO LrVtn1h/r05DqG41szH5SAkKGK/ce0MRPAoWyYvIE77yiHT9PtYB8mc7dg1L0KHLhfeO LWElwVOkkHE2w6ucF1b8+pXzncWi7zbuVozDNDNGBgDtqkJTynKzNOrc6wHgh0wrj8Dg zl1Q== MIME-Version: 1.0 X-Received: by 10.50.53.180 with SMTP id c20mr3128591igp.15.1361777323120; Sun, 24 Feb 2013 23:28:43 -0800 (PST) Received: by 10.64.63.12 with HTTP; Sun, 24 Feb 2013 23:28:42 -0800 (PST) Received: by 10.64.63.12 with HTTP; Sun, 24 Feb 2013 23:28:42 -0800 (PST) In-Reply-To: References: <201302250425.r1P4Pc9u020378@svn.freebsd.org> <512AF924.40504@yandex.ru> Date: Mon, 25 Feb 2013 07:28:42 +0000 Message-ID: Subject: Re: svn commit: r312904 - head/net-im/imspector From: Chris Rees To: araujo@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Po-Chien Lin , Ruslan Makhmatkhanov , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2013 07:28:43 -0000 On 25 Feb 2013 05:51, "Marcelo Araujo" wrote: > > > > 2013/2/25 Ruslan Makhmatkhanov >> >> Hi, >> >> Marcelo Araujo wrote on 25.02.2013 08:35: >> >>> 2013/2/25 Po-Chien Lin >>> >>>> Author: pclin >>>> Date: Mon Feb 25 04:25:37 2013 >>>> New Revision: 312904 >>>> URL: http://svnweb.freebsd.org/changeset/ports/312904 >>>> >>>> Log: >>>> - Add IPFW suuport [1] and enable it by default [2] >>>> - Trim Makefile header [2] >>>> - Remove invalid entry from MASTER_SITES >>>> - Patch to fix clang compiling >>>> - Tune pkg-plist to pet portlint(1) >>>> >>>> PR: ports/175765 >>>> Submitted by: Oleg_Sch <7zsfx@7zsfx.info> [1] >>>> Approved by: Mikhail Tsatsenko (maintainer) [2] >>>> Approved by: swills (mentor) >>>> >>>> >>> Dear Po-Chien, >>> >>> For my eyes, it is pretty much strange when we have two lines of "Approved >>> by" or more then one line of Submitted by or wherever, usually we use only >>> one line, and something like bellow: >>> >>> Approve by: Mikhail Tsatsenko (maintainer) >>> swills (mentor) >>> >>> An example to submit: >>> >>> PR: ports/1111 [1], ports/22222 [2], ports/33333 [3] >> >> >> Will this line be expanded up to three gnats followups (with commit message) for three different pr's? >> If I recall correctly it was suggested to use exactly this form to make sure everything is right: >> >> PR: ports/1111 [1] >> PR: ports/22222 [2] >> PR: ports/33333 [3] >> >> And I stick this style because of that reason. Can anybody clarify (once again)? >> > > > Yes, would be great if we have more comments, because in the section 16.3 of committers guid[1] does not mention nothing about it. > > [1] http://www.freebsd.org/doc/en/articles/committers-guide/article.html Po-Chien Lin's method is much easier for scripts to parse. Chris