From owner-freebsd-hackers Wed Jan 27 13:44:34 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA15179 for freebsd-hackers-outgoing; Wed, 27 Jan 1999 13:44:34 -0800 (PST) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from whistle.com (s205m131.whistle.com [207.76.205.131]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA15173 for ; Wed, 27 Jan 1999 13:44:32 -0800 (PST) (envelope-from archie@whistle.com) Received: (from smap@localhost) by whistle.com (8.7.5/8.6.12) id NAA21761; Wed, 27 Jan 1999 13:44:00 -0800 (PST) Received: from bubba.whistle.com( 207.76.205.7) by whistle.com via smap (V2.0) id xma021759; Wed, 27 Jan 99 13:43:53 -0800 Received: (from archie@localhost) by bubba.whistle.com (8.8.7/8.6.12) id NAA15348; Wed, 27 Jan 1999 13:43:53 -0800 (PST) From: Archie Cobbs Message-Id: <199901272143.NAA15348@bubba.whistle.com> Subject: Re: Verification of bug in dev/pdq/pdq.c In-Reply-To: <199901271934.LAA47551@apollo.backplane.com> from Matthew Dillon at "Jan 27, 99 11:34:38 am" To: dillon@apollo.backplane.com (Matthew Dillon) Date: Wed, 27 Jan 1999 13:43:53 -0800 (PST) Cc: hackers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Matthew Dillon writes: > cc -c -O -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing > -prototypes -Wpointer-arith -Winline -Wcast-qual -fformat-extensions -ansi -no > stdinc -I- -I. -I../.. -I../../../include -DKERNEL -include opt_global.h -elf > ../../dev/pdq/pdq.c > ../../dev/pdq/pdq.c: In function `pdq_process_received_data': > ../../dev/pdq/pdq.c:767: warning: suggest parentheses around comparison in opera > nd of | > > } else if (status.rxs_fsc == 0 | status.rxs_fsb_e == 1) { > /* rx->rx_frame_status_errors++; */ > > > I presume the '|' instead of '||' is a bug. Second opinion? It must be -- that makes no sense. Anyway, it doesn't matter if you change it, because the result will be functionally identical. -Archie ___________________________________________________________________________ Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message