Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 20 Dec 1997 22:39:27 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, jb@freebsd1.cimlogic.com.au
Cc:        bde@FreeBSD.ORG, current@FreeBSD.ORG, grog@lemis.com, julian@whistle.com
Subject:   Re: Bruce vandalism again
Message-ID:  <199712201139.WAA04443@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>If the use of the __P macro in new code is discouraged, then FreeBSD is
>not trying to keep K&R compatibility (like NetBSD insists on). So we are
>*encouraging* ANSI prototypes. Then (IMO) code that is being edited (for
>other reasons) should have its function definitions changed to ANSI style
>at the same time, regardless of how much code is regarded as new according
>to this silly statement.....

A great way to enlarge 200000-line diffs between NetBSD and FreeBSD for code
that isn't really different :-(.

>>      In general code can be considered ``new code'' when it makes up about 50%
>>      or more of the file[s] involved.  This is enough to break precedents in
>>      the existing code and use the current style guidelines.
>
>Now is that 50% of the code that makes up the function definitions or do
>we have to count all the other lines of code too?!

All lines.  I would only count significant changes like rewriting vm.

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712201139.WAA04443>