Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Dec 2017 22:42:10 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        "Sergey A. Osokin" <osa@FreeBSD.org>, Mathieu Arnold <mat@FreeBSD.org>
Cc:        "Tobias C. Berner" <tcberner@gmail.com>, Jochen Neumeister <joneum@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r456286 - head/www/nginx
Message-ID:  <e646813b-7b29-b627-2ad2-feac14c56bf1@FreeBSD.org>
In-Reply-To: <20171215213632.GH81079@FreeBSD.org>
References:  <201712141007.vBEA74si099181@repo.freebsd.org> <20171215004922.GD81079@FreeBSD.org> <CAOshKteziQnzdjaV5xuZgT6GqX=PNu5-x78aAFut2x2bo6s3BA@mail.gmail.com> <20171215194054.GG81079@FreeBSD.org> <6b68b8ee-86ad-e941-c021-60059891fbe9@FreeBSD.org> <20171215213632.GH81079@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Le 15/12/2017 =C3=A0 22:36, Sergey A. Osokin a =C3=A9crit=C2=A0:
> On Fri, Dec 15, 2017 at 10:04:58PM +0100, Mathieu Arnold wrote:
>> Le 15/12/2017 ?? 20:40, Sergey A. Osokin a ??crit=C2=A0:
>>> Hi Tobias,
>>>
>>> objection because third-party fancyindex module update doesn't affect=

>>> the final package anyhow.
>> You mean that if you enable the fancyindex option, it is not compiled =
in
>> ? I do not understand.
> I've provided my explanation in previous email, so again - since third-=
party
> fancyindex module isn't enabled by default, the update of the module
> doesn't affect the final www/nginx package and this is why the PORTREVI=
SION
> bump is needless here.  Hope it's clear.

Let me quote what the porter's handbook say, again, please read it very
carefuly:

=C2=A0=C2=A0 PORTREVISION must be increased each time a change is made to=

=C2=A0=C2=A0 the port that changes the generated package in any way. That=

=C2=A0=C2=A0 includes changes that only affect a package built with
=C2=A0=C2=A0 non-default options.

This means that if you change the port so that what gets installed,
whatever the default options are, is changed, you MUST bump PORTREVISION.=


I do not understand how you constantly fail to understand this.

--=20
Mathieu Arnold





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?e646813b-7b29-b627-2ad2-feac14c56bf1>