From owner-svn-ports-head@FreeBSD.ORG Fri Oct 18 16:28:39 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 24C917EC; Fri, 18 Oct 2013 16:28:39 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 9C06A2F8C; Fri, 18 Oct 2013 16:28:38 +0000 (UTC) Received: from mercury.ph.man.ac.uk [130.88.75.175:45863] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with LOGIN) by mail.issp.ac.ru with ESMTP/inet id r9IGSHqR010231 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Fri, 18 Oct 2013 20:28:19 +0400 (MSK) From: Max Brazhnikov To: Dmitry Marakasov Subject: Re: svn commit: r330501 - head/deskutils/qrfcview Date: Fri, 18 Oct 2013 16:28:19 +0000 Message-ID: <5760775.4keyzDQcE0@mercury.ph.man.ac.uk> User-Agent: KMail/4.11 (FreeBSD/9.2-STABLE; KDE/4.11.0; amd64; ; ) In-Reply-To: <20131017192256.GG62015@hades.panopticon> References: <201310161249.r9GCnSFP011838@svn.freebsd.org> <1651195.G2FJH9mVfi@mercury.ph.man.ac.uk> <20131017192256.GG62015@hades.panopticon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Oct 2013 16:28:39 -0000 On Thu, 17 Oct 2013 23:22:56 +0400 Dmitry Marakasov wrote: > * Max Brazhnikov (makc@freebsd.org) wrote: > > > I suppose your c++ is actually g++ > > It may be, it may be not. Anyway, if g++ shows itself in the build, > compiler is not respected. Another example: > > % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1 > g++ -c -O2 -pipe -march=nocona ... > > with my qmake.mk patch: > > % CC="ccache cc" CXX="ccache c++" make all clean 2>&1 | grep -- -c | head -1 > ccache c++ -c -O2 -pipe -march=nocona ... > > > > That's because QMAKEFLAGS contains QMAKE_CC and friends, but > > > QMAKE_ARGS from Uses/qmake.mk doesn't. > > > > it doesn't need to: compiler is already respected via QMAKESPEC, > > QMAKE_CC, etc are redundant. > > No, QMAKESPEC is just a bunch of hardcoded values - it respects nothing. QMAKESPEC is set in accordance with CXX value, but I see your point, so I propose the following patch http://people.freebsd.org/~makc/patches/bsd.qt.mk.diff btw, in case you have missed one of my previous mail, there is one more patch for you http://people.freebsd.org/~makc/patches/qnetwalk.diff Cheers, Max