From owner-freebsd-audit  Fri Jan 18  2:25:12 2002
Delivered-To: freebsd-audit@freebsd.org
Received: from straylight.ringlet.net (discworld.nanolink.com [217.75.135.248])
	by hub.freebsd.org (Postfix) with SMTP id 2D4AB37B416
	for <audit@freebsd.org>; Fri, 18 Jan 2002 02:25:06 -0800 (PST)
Received: (qmail 31291 invoked by uid 1000); 18 Jan 2002 10:25:57 -0000
Date: Fri, 18 Jan 2002 12:25:57 +0200
From: Peter Pentchev <roam@ringlet.net>
To: Mark Murray <mark@grondar.za>
Cc: audit@freebsd.org
Subject: Re: Fixes for gid_t usage in libc
Message-ID: <20020118122557.C305@straylight.oblivion.bg>
Mail-Followup-To: Mark Murray <mark@grondar.za>, audit@freebsd.org
References: <200201172200.g0HM0St19717@grimreaper.grondar.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200201172200.g0HM0St19717@grimreaper.grondar.org>; from mark@grondar.za on Thu, Jan 17, 2002 at 10:00:28PM +0000
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

On Thu, Jan 17, 2002 at 10:00:28PM +0000, Mark Murray wrote:
> Hi
> 
> Reviews please?
> 
> This fixes some places where groups are handled in integers
> rather than gid_t's.
> 
> I've been running it for more than a month.

There are a lot more :)  Just changing grp.h to use gid_t might
break a couple of WARNSified programs, I think..

> Index: lib/libc/gen/getgrouplist.c
> ===================================================================
> RCS file: /home/ncvs/src/lib/libc/gen/getgrouplist.c,v
> retrieving revision 1.7
> diff -u -d -r1.7 getgrouplist.c
> --- lib/libc/gen/getgrouplist.c	12 Mar 1997 14:54:22 -0000	1.7
> +++ lib/libc/gen/getgrouplist.c	14 Dec 2001 15:29:19 -0000
> @@ -31,9 +31,12 @@
>   * SUCH DAMAGE.
>   */
>  
> +#include <sys/cdefs.h>
> +__FBSDID("$FreeBSD$");
> +

Isn't <sys/cdefs.h> kind of an implementation detail?  I think
that <sys/types.h> is supposed to be used for FBSDID's..
I might be wrong, of course.

Could this one not be redone by placing the FBSDID after
the other includes, though?

G'luck,
Peter

-- 
What would this sentence be like if it weren't self-referential?

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message