Date: Tue, 22 May 2007 12:44:41 +0200 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Robert Watson <rwatson@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Alfred Perlstein <alfred@freebsd.org>, Andre Oppermann <andre@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_syscalls.c Message-ID: <863b1pyw6e.fsf@dwp.des.no> In-Reply-To: <20070522112825.U50138@fledge.watson.org> (Robert Watson's message of "Tue\, 22 May 2007 11\:28\:46 %2B0100 \(BST\)") References: <200705192051.l4JKp0rF074703@repoman.freebsd.org> <20070522003856.GX21795@elvis.mu.org> <20070522112825.U50138@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson <rwatson@FreeBSD.org> writes: > Alfred Perlstein <alfred@freebsd.org> writes: > > Is this the same bug that used to be in sendfile but got corrected > > some years back? > Dunno, but it sounds like we really need a comprehensive set of > edge-case tests for sendfile. This was not an edge case. The edge case (no offset, no length, no header) was the one that worked; it was the non-trivial case (non-zero offset, explicit length, non-empty header) that was broken. Nobody noticed because existing code (Apache, ftpd) only exercises the edge case. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?863b1pyw6e.fsf>