Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jul 2011 11:33:55 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        John Hein <jhein@symmetricom.com>
Cc:        vanhu@netasq.com, Stephen Montgomery-Smith <stephen@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, maho@FreeBSD.org, cvs-ports@FreeBSD.org
Subject:   Re: cvs commit: ports/security/ipsec-tools Makefile ports/security/ipsec-tools/files racoon.sh.in
Message-ID:  <4E25CE13.6050507@FreeBSD.org>
In-Reply-To: <20005.42751.457047.15851@gossamer.timing.com>
References:  <201107190333.p6J3XQVD050847@repoman.freebsd.org> <4E2542BA.5040203@FreeBSD.org> <20005.42751.457047.15851@gossamer.timing.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 07/19/2011 08:47, John Hein wrote:
> Doug Barton wrote at 01:39 -0700 on Jul 19, 2011:
>  > This change is an improvement, but it doesn't go far enough in a couple
>  > of directions. The 2 most important being that faststart is not the only
>  > possible prefix there, and we don't want that block to run
>  > unconditionally in any case.
>  > 
>  > I've attached the full script I'm suggesting because the diff doesn't
>  > make much sense. One thing I didn't change because I'm not sure if it
>  > needs to be run early is changing the current require/before to just
>  > REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if
>  > there is a good reason for this one to run earlier, that's fine.
>  > 
>  > If you have any questions, let me know.
> 
> Yes, looks good to me.  Well, except the spelling issues:
> 
> sed -E 's,(raccon|raccoon),racoon,g'

Sorry about that. For some reason I had a heck of a time typing that
word last night.

> I'm not sure if there are some lurking subtleties regarding the
> require/before question.  I'll let Yvan answer that.  Commit
> history doesn't say anything - it's been REQUIRE: DAEMON &
> BEFORE: LOGIN since the beginning - probably just copy/pasted.

Yes, that's very likely.



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4E25CE13.6050507>