From owner-cvs-ports@FreeBSD.ORG Tue Jul 19 18:35:01 2011 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 7635C1065673; Tue, 19 Jul 2011 18:35:01 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 6B2C820050E; Tue, 19 Jul 2011 18:33:57 +0000 (UTC) Message-ID: <4E25CE13.6050507@FreeBSD.org> Date: Tue, 19 Jul 2011 11:33:55 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:5.0) Gecko/20110706 Thunderbird/5.0 MIME-Version: 1.0 To: John Hein References: <201107190333.p6J3XQVD050847@repoman.freebsd.org> <4E2542BA.5040203@FreeBSD.org> <20005.42751.457047.15851@gossamer.timing.com> In-Reply-To: <20005.42751.457047.15851@gossamer.timing.com> X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: vanhu@netasq.com, Stephen Montgomery-Smith , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, maho@FreeBSD.org, cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/security/ipsec-tools Makefile ports/security/ipsec-tools/files racoon.sh.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 18:35:01 -0000 On 07/19/2011 08:47, John Hein wrote: > Doug Barton wrote at 01:39 -0700 on Jul 19, 2011: > > This change is an improvement, but it doesn't go far enough in a couple > > of directions. The 2 most important being that faststart is not the only > > possible prefix there, and we don't want that block to run > > unconditionally in any case. > > > > I've attached the full script I'm suggesting because the diff doesn't > > make much sense. One thing I didn't change because I'm not sure if it > > needs to be run early is changing the current require/before to just > > REQUIRE: LOGIN, which is what we prefer ports scripts to do. However if > > there is a good reason for this one to run earlier, that's fine. > > > > If you have any questions, let me know. > > Yes, looks good to me. Well, except the spelling issues: > > sed -E 's,(raccon|raccoon),racoon,g' Sorry about that. For some reason I had a heck of a time typing that word last night. > I'm not sure if there are some lurking subtleties regarding the > require/before question. I'll let Yvan answer that. Commit > history doesn't say anything - it's been REQUIRE: DAEMON & > BEFORE: LOGIN since the beginning - probably just copy/pasted. Yes, that's very likely. -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/