From owner-dev-commits-src-main@freebsd.org Tue Mar 16 07:39:59 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6666457A4AA; Tue, 16 Mar 2021 07:39:59 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mx.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F04v26YMkz3QHm; Tue, 16 Mar 2021 07:39:58 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1615880397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3BAIJ4GR2kRWqB6mNHE9q2IJwz6Gj3mgNxmUB/H9gk=; b=WQjRUQhiUnQgC/LvLQBTPG5ihL9Qorthbxs5yNVgm8XQEwsriGWWbQgHYQhuNRlAx5IFri hZzvqU6S1mPVA5w0i0DLMRXEUXboxckpPDbWsg1CSLR3Thx3p1HGOJsLnJmInh4fR/SUwB tbYLVU61pi/cTfy/w2bCoLXgEuDACeA= Received: from amy (lfbn-idf2-1-644-4.w86-247.abo.wanadoo.fr [86.247.100.4]) by mx.blih.net (OpenSMTPD) with ESMTPSA id edd5a809 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 16 Mar 2021 07:39:57 +0000 (UTC) Date: Tue, 16 Mar 2021 08:39:57 +0100 From: Emmanuel Vadot To: Konstantin Belousov Cc: Emmanuel Vadot , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 0006530aa14b - main - include: Remove symlink installation Message-Id: <20210316083957.540d3978e5b0160db2104fa1@bidouilliste.com> In-Reply-To: References: <202103160613.12G6DLYL061995@gitrepo.freebsd.org> <20210316081214.0ba83981a37b8b3b9e5589bd@bidouilliste.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4F04v26YMkz3QHm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 07:39:59 -0000 On Tue, 16 Mar 2021 09:17:36 +0200 Konstantin Belousov wrote: > On Tue, Mar 16, 2021 at 08:12:14AM +0100, Emmanuel Vadot wrote: > > On Tue, 16 Mar 2021 08:52:07 +0200 > > Konstantin Belousov wrote: > > > > > On Tue, Mar 16, 2021 at 06:13:21AM +0000, Emmanuel Vadot wrote: > > > > The branch main has been updated by manu: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=0006530aa14b9df56f88df7d819fae89b115d865 > > > > > > > > commit 0006530aa14b9df56f88df7d819fae89b115d865 > > > > Author: Emmanuel Vadot > > > > AuthorDate: 2021-03-16 06:12:53 +0000 > > > > Commit: Emmanuel Vadot > > > > CommitDate: 2021-03-16 06:12:53 +0000 > > > > > > > > include: Remove symlink installation > > > > > > > > headers could be installed as symlink to the source tree instead of copies. > > > > Remove the possibility to do that. > > > > This make the makefile easier to read and to maintain and also don't duplicate > > > > code. > > > > > > > > While here remove some directories from LSBUDIRS as we already install them using > > > > the INCS stuff. > > > > > > This might make Makefiles easier to read, but also it makes practically > > > very hard to develop rtld/libc/libthr. After any system header > > > modification, full buildworld or at least kernel-toolchain run is > > > required to get buildenv populated with the new headers. > > > > Can you share what you did before so I can cook a patch that restore > > this behavior in a better way than it was done before ? > > I did > $ make buildworld <- this was done relatively irregularly > $ make buildenv > [Edit whatever I needed, typically in sys/sys and libexec/rtld-elf] > $ cd libexec/rtld-elf > $ make DEBUG_FLAGS=-g WITHOUT_TESTS=yes all > [Check built ld-elf.so.1, more edits] > $ make ... > > Now, if I modify anything in sys/, I have to repopuate staged headers in > the obj directory of buildworld. Right ok, I've missed that SHARED=symlinks was used in Makefile.inc1, I'll revert and redo a better patch. -- Emmanuel Vadot