Date: Fri, 18 May 2018 17:20:09 -0700 From: Eitan Adler <lists@eitanadler.com> To: Kurt Jaeger <lists@opsec.eu> Cc: "John W. O'Brien" <john@saltant.com>, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: Practice of "Sponsored by" in commit messages Message-ID: <CAF6rxgn=tT_H9iike1n=4xFFJ1ocr0K0gF70G02TRrZXBJ1mig@mail.gmail.com> In-Reply-To: <20180518182005.GG37752@home.opsec.eu> References: <CAH7qZfs8eNMkkeQ0eyV5AcapOCQFFL1fUiBDR1aM1875-Cy-Lg@mail.gmail.com> <3cc77471-4200-1f45-e83d-2ae4d636f4fa@saltant.com> <CAH7qZfu6j%2Bc-HpjHnwxyeQTKwX9DavN4iAzSpMO5Kjy9VJ2uHw@mail.gmail.com> <732c3f40-1765-6883-dbec-f5c77db8e30c@saltant.com> <CAH7qZftNadmygyPNW9HNPWTY9kU6W7j-409CrV0XGk6ZYDQTug@mail.gmail.com> <7b14a5c4-7320-8f5e-b8c3-f49809caf9e5@saltant.com> <20180518041501.GF37752@home.opsec.eu> <CAF6rxgnHeSEAOw_qbMeWEiSEX3dbcu7ASPBVthsCXkaZ%2Bf%2BBaQ@mail.gmail.com> <31190803-e6ba-428b-0954-341dad2f1916@saltant.com> <CAF6rxgmNL2pRJwJUz39Cfw=Di5sfhN3PvSCfwTrsupQ86gHcFw@mail.gmail.com> <20180518182005.GG37752@home.opsec.eu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18 May 2018 at 11:20, Kurt Jaeger <lists@opsec.eu> wrote: > Hi! > >> >>>> The FreeBSD project could help by asking committers to qualify >> >>>> "Sponsored by" lines to indicate which participant(s) is(are) sponsored, >> >>>> in way that is equivalent to the way that the actual work itself is >> >>>> customarily attributed. > >> >>> This sounds reasonable, so I suggest that you submit a >> >>> patch to the ports handbook that describes it for maintainers >> >>> and committers. > >> >> One thing to note: FreeBSD has a custom patch to subversion to detect >> >> "ORGANIZATION_NAME" and automatically append it to the default >> >> template. This is likely why its getting added in unexpected places. > >> > How do you think I should handle that in my forthcoming doc patch? Is >> > there a related bug I should file against services? > >> Its a client side patch of the subversion binary. I'm not sure the >> best way to handle it beyond perhaps changing the template a bit? > > What change would be needed ? There's already a Sponsored by field ? My point is that the custom patch pre-fills the field, which is why submitters often see it filled when they don't expect it: the committer doesn't do it by hand. -- Eitan Adler
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgn=tT_H9iike1n=4xFFJ1ocr0K0gF70G02TRrZXBJ1mig>