From owner-svn-src-all@freebsd.org Fri May 25 21:25:27 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEC41EF4DEE for ; Fri, 25 May 2018 21:25:27 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49F82754F2 for ; Fri, 25 May 2018 21:25:26 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: 1f6b65ac-6062-11e8-8837-614b7c574d04 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.ore.mailhop.org (Halon) with ESMTPSA id 1f6b65ac-6062-11e8-8837-614b7c574d04; Fri, 25 May 2018 21:25:19 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w4PLPIpV008111; Fri, 25 May 2018 15:25:18 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1527283518.32688.164.camel@freebsd.org> Subject: Re: svn commit: r333407 - head/share/mk From: Ian Lepore To: Bryan Drewery , Brad Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Fri, 25 May 2018 15:25:18 -0600 In-Reply-To: <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org> References: <201805091344.w49Dist5061908@repo.freebsd.org> <88989fda-4d0b-af16-8d08-28b6cdba0d34@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 May 2018 21:25:27 -0000 On Fri, 2018-05-25 at 14:10 -0700, Bryan Drewery wrote: > On 5/9/2018 6:44 AM, Brad Davis wrote: > > > > Author: brd > > Date: Wed May  9 13:44:54 2018 > > New Revision: 333407 > > URL: https://svnweb.freebsd.org/changeset/base/333407 > > > > Log: > >   Enable directory creation with FILESDIR. > >    > >   This is part of packaging base work. > >    > >   Reviewed by: will > >   Approved by: bapt (mentor), allanjude (mentor) > >   Differential Revision: https://reviews.freebsd.org/D15130 > > > Please update share/mk/bsd.README too. > > I know I haven't been very responsive but it's partly because I'm still > fundamentally against this feature. It's adding a mechanism to replace > mtree without considering the whole picture and only binding it to FILES > rather than a bsd.dirs.mk; It doesn't actually satisfy replacing mtree > files since it only works if there is a FILESGROUP used (FILES must be > non-empty). So what's the point? My major concern is added confusion. > The creation of directories for installing is a pain point at work for > developers but I don't think this is enough. I liked the idea of > `install "-D"` but I know it's not efficient and had some implementation > issues. I welcome this work. If it's not complete/perfect, we can iterate towards that, but mtree is not a good solution for out-of-tree builds that use the build machinery in /usr/share/mk. The lack of a solution other than mtree has led to half a dozen different hacks scattered around the makefiles in our application repo, and it's about time this hole in the build system gets plugged. -- Ian