Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Jun 2004 17:52:29 -0600
From:      Greg Lewis <glewis@eyesbeyond.com>
To:        Kirill Ponomarew <krion@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/math/gnuplot Makefile
Message-ID:  <20040627235229.GA36136@misty.eyesbeyond.com>
In-Reply-To: <200406271812.i5RICLjj014328@repoman.freebsd.org>
References:  <200406271812.i5RICLjj014328@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jun 27, 2004 at 06:12:21PM +0000, Kirill Ponomarew wrote:
> krion       2004-06-27 18:12:21 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     math/gnuplot         Makefile 
>   Log:
>   Fix OPTIONS
>   
>   PR:             ports/68388
>   Submitted by:   Ports Fury

So, what exactly is wrong with doing

.if defined(WITH_OPTION)
stuff
.else
other stuff
.endif

that

.if defined(WITHOUT_OPTION)
other stuff
.else
stuff
.endif

fixes?  The only thing I can think of is that it may be prefered to test the
WITHOUT_OPTION variable when the default is on.  Is that it?

Also, why wasn't the PR assigned to the maintainer (me :)?

-- 
Greg Lewis                          Email   : glewis@eyesbeyond.com
Eyes Beyond                         Web     : http://www.eyesbeyond.com
Information Technology              FreeBSD : glewis@FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040627235229.GA36136>