From owner-freebsd-stable@FreeBSD.ORG Sun Feb 20 18:02:44 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B6ADC1065673 for ; Sun, 20 Feb 2011 18:02:44 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id 72BCC8FC16 for ; Sun, 20 Feb 2011 18:02:44 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApwEAKvlYE2DaFvO/2dsb2JhbACEIKMFqgePSYRodgSFDYcG X-IronPort-AV: E=Sophos;i="4.62,195,1297054800"; d="scan'208";a="110489104" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 20 Feb 2011 13:02:43 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 7C85FB3FF4; Sun, 20 Feb 2011 13:02:43 -0500 (EST) Date: Sun, 20 Feb 2011 13:02:43 -0500 (EST) From: Rick Macklem To: Kirill Yelizarov Message-ID: <2058422254.149547.1298224963499.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: <795118.6346.qm@web120517.mail.ne1.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_149546_2038487835.1298224963498" X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - IE8 (Win)/6.0.10_GA_2692) Cc: freebsd-stable@freebsd.org Subject: Re: NFS client over udp X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Feb 2011 18:02:44 -0000 ------=_Part_149546_2038487835.1298224963498 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit > --- On Fri, 2/18/11, Kirill Yelizarov > > > On Fri, Feb 18, 2011 at 05:27:00AM > > > -0800, Kirill Yelizarov wrote: > > > > I have a reproducible memory leak when using nfs > > > client with an old > > > > nfs server > > and mbufs used > 8193/1722/9915 mbufs in use (current/cache/total) > 8192/1264/9456/25600 mbuf clusters in use (current/cache/total/max) > 8192/605 mbuf+clusters out of packet secondary zone in use > (current/cache) > 0/768/768/12800 4k (page size) jumbo clusters in use > (current/cache/total/max) > 0/0/0/6400 9k jumbo clusters in use (current/cache/total/max) > 0/0/0/3200 16k jumbo clusters in use (current/cache/total/max) > 18432K/6030K/24462K bytes allocated to network (current/cache/total) > 0/0/0 requests for mbufs denied (mbufs/clusters/mbuf+clusters) > 0/0/0 requests for jumbo clusters denied (4k/9k/16k) > 0/0/0 sfbufs in use (current/peak/max) > 0 requests for sfbufs denied > 0 requests for sfbufs delayed > 0 requests for I/O initiated by sendfile > 0 calls to protocol drain routines > > Kirill > You could try the attached patch. It fixes the only places in the client side krpc over udp that seems mights cause a leak. I have no idea if it will help, since these cases should rarely, if ever, happen in practice. Please let us know if you have the chance to try the patch and whether or not it helped. rick ------=_Part_149546_2038487835.1298224963498 Content-Type: text/x-patch; name=clntdg.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=clntdg.patch LS0tIHJwYy9jbG50X2RnLmMuc2F2CTIwMTEtMDItMTkgMTk6NTI6NDEuMDAwMDAwMDAwIC0wNTAw CisrKyBycGMvY2xudF9kZy5jCTIwMTEtMDItMjAgMTA6NDM6MTEuMDAwMDAwMDAwIC0wNTAwCkBA IC03MDQsOSArNzA0LDkgQEAgZ290X3JlcGx5OgogCQkgICAgKHJlcGx5X21zZy5hY3B0ZWRfcnBs eS5hcl9zdGF0ID09IFNVQ0NFU1MpKQogCQkJZXJycC0+cmVfc3RhdHVzID0gc3RhdCA9IFJQQ19T VUNDRVNTOwogCQllbHNlCi0JCQlzdGF0ID0gX3NldGVycl9yZXBseSgmcmVwbHlfbXNnLCAmKGN1 LT5jdV9lcnJvcikpOworCQkJc3RhdCA9IF9zZXRlcnJfcmVwbHkoJnJlcGx5X21zZywgZXJycCk7 CiAKLQkJaWYgKGVycnAtPnJlX3N0YXR1cyA9PSBSUENfU1VDQ0VTUykgeworCQlpZiAoc3RhdCA9 PSBSUENfU1VDQ0VTUykgewogCQkJcmVzdWx0cyA9IHhkcm1idWZfZ2V0YWxsKCZ4ZHJzKTsKIAkJ CWlmICghIEFVVEhfVkFMSURBVEUoYXV0aCwgeGlkLAogCQkJCSZyZXBseV9tc2cuYWNwdGVkX3Jw bHkuYXJfdmVyZiwKQEAgLTEwODksMTEgKzEwODksMTQgQEAgY2xudF9kZ19zb3VwY2FsbChzdHJ1 Y3Qgc29ja2V0ICpzbywgdm9pZAogCQkvKgogCQkgKiBUaGUgWElEIGlzIGluIHRoZSBmaXJzdCB1 aW50MzJfdCBvZiB0aGUgcmVwbHkuCiAJCSAqLwotCQlpZiAobS0+bV9sZW4gPCBzaXplb2YoeGlk KSAmJiBtX2xlbmd0aChtLCBOVUxMKSA8IHNpemVvZih4aWQpKQorCQlpZiAobS0+bV9sZW4gPCBz aXplb2YoeGlkKSAmJiBtX2xlbmd0aChtLCBOVUxMKSA8IHNpemVvZih4aWQpKSB7CiAJCQkvKgog CQkJICogU2hvdWxkIG5ldmVyIGhhcHBlbi4KIAkJCSAqLworCQkJcHJpbnRmKCJjbG50X2RnX3Nv dXBjYWxsOiByZWNlaXZlZCBnYXJiYWdlXG4iKTsKKwkJCW1fZnJlZW0obSk7CiAJCQljb250aW51 ZTsKKwkJfQogCiAJCW1fY29weWRhdGEobSwgMCwgc2l6ZW9mKHhpZCksIChjaGFyICopJnhpZCk7 CiAJCXhpZCA9IG50b2hsKHhpZCk7Cg== ------=_Part_149546_2038487835.1298224963498--