From owner-freebsd-stable@freebsd.org Fri Aug 12 08:27:49 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88527BB7FBF for ; Fri, 12 Aug 2016 08:27:49 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0054.outbound.protection.outlook.com [65.55.169.54]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C48051159; Fri, 12 Aug 2016 08:27:48 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from YTOPR01MB0412.CANPRD01.PROD.OUTLOOK.COM (10.166.150.148) by YTOPR01MB0409.CANPRD01.PROD.OUTLOOK.COM (10.166.150.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Thu, 11 Aug 2016 22:53:03 +0000 Received: from YTOPR01MB0412.CANPRD01.PROD.OUTLOOK.COM ([10.166.150.148]) by YTOPR01MB0412.CANPRD01.PROD.OUTLOOK.COM ([10.166.150.148]) with mapi id 15.01.0549.025; Thu, 11 Aug 2016 22:53:03 +0000 From: Rick Macklem To: Harry Schmalzbauer , Mark Johnston CC: FreeBSD Stable , "kib@FreeBSD.org" Subject: Re: unionfs bugs, a partial patch and some comments [Was: Re: 1-BETA3 Panic: __lockmgr_args: downgrade a recursed lockmgr nfs @ /usr/local/share/deploy-tools/RELENG_11/src/sys/fs/unionfs/union_vnops.c:1905] Thread-Topic: unionfs bugs, a partial patch and some comments [Was: Re: 1-BETA3 Panic: __lockmgr_args: downgrade a recursed lockmgr nfs @ /usr/local/share/deploy-tools/RELENG_11/src/sys/fs/unionfs/union_vnops.c:1905] Thread-Index: AQHR8Usp3UC6l4vlEEOdyPFAeIRbFKBAJI+AgAA/AgCAA/TscA== Date: Thu, 11 Aug 2016 22:53:03 +0000 Message-ID: References: <57A79E24.8000100@omnilan.de> <57A83C78.1070403@omnilan.de> <20160809060213.GA67664@raichu>,<57A9A6C0.9060609@omnilan.de> In-Reply-To: <57A9A6C0.9060609@omnilan.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rmacklem@uoguelph.ca; x-originating-ip: [24.57.164.61] x-ms-office365-filtering-correlation-id: 57554832-f76b-4eb7-6105-08d3c23a4074 x-microsoft-exchange-diagnostics: 1; YTOPR01MB0409; 6:MgBpH9/hQyvsN8AE+Nkimvt651D5aMOhQCbcl+bDlhvfU9rMLEJs1oRKIIVZVMFS6paWbIKIu7mzBxM3GK3HZPJNR4jlyaWHwvYzjcDremKifsK/Wal/sujloMBkC2i5i2uqYzRilGVgWhZpv8hwNgTM7S3OUrDOscf409v7ylB5vAxqyK/ZlXnV8SYbVlhfGNoRPIBsfv1ta3EEz1XQsNBnXiWYXzNJzabYHJHrTEiV+MOIJOPpJT0FyRZ2YYR8pfx08tBWqFDkWVICO66g4RG1HKcICA8Z9+T97rXPOPy2aEj2QIwiNm8vhx1HjERY; 5:kC4Htf9biXUW3MeM6toW6U3GFXgrevuRf1fd1Pp2RV9+prdXy7YA1WbyLhSlHxjf/VjDQ89lE0BCBYcrt+0ml36wII2IjoU+uR9piaAaw6jXiQnY3KnmY81SPPVtIutkk4X90YxzKEwZsFyNvAj93w==; 24:lyKt69ws9jtrJ2zPXx+0g03SBqlTtw8TAe71kocsyImrl2KAGr88a2pLA/kOnzl/UdO6Prnw9ptVY7jkoAWaJ/V9RqknvZXtAS+SqAq89f8=; 7:aINgsdUllJ8w16GYcQ6XLJNLcft8J+rnU0mgan9cDNhJZeT8S7CTAjMZRzhF5z4VwcMi5oDjSWu//SO2U2vWKJFE2GPt17miGATVoMqrc60Q0XMEnUcmFmoRSQyfdUAS0vtoQpuUtvLJBAP5TSlBncCVo02egN1nDf/SwdKR88Wp74KgJOV4w9kskgXQF7T3goXcLb5mS8GvA63bfi943TN6HfWZ2igct1saEKp3aKAym4lRGJ2DJEgrYR1nU51V x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:YTOPR01MB0409; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(155532106045638); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(102415321)(6040130)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046); SRVR:YTOPR01MB0409; BCL:0; PCL:0; RULEID:; SRVR:YTOPR01MB0409; x-forefront-prvs: 0031A0FFAF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916002)(24454002)(199003)(189002)(3660700001)(19627595001)(105586002)(2906002)(77096005)(15975445007)(9686002)(11100500001)(106116001)(74482002)(50986999)(8936002)(19627405001)(92566002)(81166006)(99936001)(3280700002)(76176999)(54356999)(2900100001)(19580395003)(93886004)(106356001)(68736007)(66066001)(19625215002)(18206015028)(2950100001)(86362001)(19617315012)(101416001)(4326007)(10400500002)(7696003)(586003)(97736004)(102836003)(3846002)(17760045003)(33656002)(6116002)(7736002)(5890100001)(16236675004)(81156014)(7846002)(5002640100001)(189998001)(7906003)(5001770100001)(122556002)(8676002)(87936001)(74316002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:YTOPR01MB0409; H:YTOPR01MB0412.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: multipart/mixed; boundary="_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_" MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Aug 2016 22:53:03.3111 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTOPR01MB0409 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2016 08:27:49 -0000 --_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 SGFycnkgU2NobWFsemJhdWVyIHdyb3RlOg0KQmV6w7xnbGljaCBNYXJrIEpvaG5zdG9uJ3MgTmFj aHJpY2h0IHZvbSAwOS4wOC4yMDE2IDA4OjAyIChsb2NhbHRpbWUpOg0K4oCmDQo+Pg0KPj4gSnVz dCBmb3IgYW55Ym9keSBlbHNlIG5lZWRpbmcgdW5pb25mczoNCj4+IGh0dHBzOi8vcGVvcGxlLmZy ZWVic2Qub3JnL35hdHRpbGlvL3VuaW9uZnNfbWlzc2luZ19pbnNtbnRxdWVfbG9jay5wYXRjaA0K Pj4NCj4+IFRoaXMgcGF0Y2ggc3RpbGwgYXBwbGllcyBhbmQgSSdtIHN1Y2Nlc3NmdWxseSB1c2lu ZyB0aGlzICh1bm1vZGlmaWVkKSB1cA0KPj4gdG8gRnJlZUJTRC0xMC4zIGFuZCBuZXZlciBoYWQg YW55IHBhbmljIGluIGFsbCB0aGVzZSB5ZWFycy4NCj4NCj4gSGF2aW5nIHNwZW50IHNvbWUgdGlt ZSBsb29raW5nIGF0IHVuaW9uZnMsIEknbSBhIGJpdCBza2VwdGljYWwgdGhhdCB0aGlzDQo+IHBh dGNoIHdpbGwgYWRkcmVzcyB0aGUgcGFuaWMgeW91IHJlcG9ydGVkIGVhcmxpZXIsIHRob3VnaCBJ J2QgYmUNCj4gaW50ZXJlc3RlZCB0byBrbm93IGlmIGl0IGRvZXMuDQpbc3R1ZmYgc25pcHBlZCBm b3IgYnJldml0eV0NCkkgdG9vayBhIGxvb2sgYXQgdGhpcy4gKEkga25vdyBub3RoaW5nIGFib3V0 IHVuaW9uZnMsIGJ1dCBhIGxpdHRsZSB3LnIudC4gdGhlIFZGUykuDQpJIGNhbiBjb25maXJtIHRo YXQgdGhpcyBmdW5jdGlvbiAodW5pb25mc19ub2RlZ2V0KCkpIGlzIHdlaXJkIGFuZCBhcHBlYXJz IHRvDQpiZSBicm9rZW4gdG8gbWUuDQoNClRoZSBmdW5jdGlvbiBjYWxscyBpbnNtbnRxdWUoKSBi ZWZvcmUgaXQgaW5pdGlhbGl6ZXMgdGhlIHZub2RlLCB3aGljaCBzZWVtcw0KcmFjZXksIGVzcGVj aWFsbHkgaWYgaXQgaXNuJ3QgTEtfRVhDTFVTSVZFIGxvY2tlZC4NCkFsc28sIGxpbmUjcyAyNzgt MjgxOg0KICAgIGlmICh1cHBlcnZwICE9IE5VTExWUCkNCiAgICAgICAgIHZwLT52X3ZubG9jayA9 IHVwcGVydnAtPnZfdm5sb2NrOw0KICAgIGVsc2UNCiAgICAgICAgIHZwLT52X3ZubG9jayA9IGxv d2VydnAtPnZfdm5sb2NrOw0Kc28geW91ciBwYXRjaCBpc24ndCBsb2NraW5nIHRoZSB2bm9kZSBs b2NrIHRoYXQgaXQgYWN0dWFsbHkgdXNlcy4NCkkgdGhpbmsgdGhlIHZwIGFyZ3VtZW50IHRvIGlu c21udHF1ZSgpIGlzIHJlcXVpcmVkIHRvIGJlIExLX0VYQ0xVU0lWRQ0KbG9ja2VkIG1vc3RseSBz byBvdGhlciB0aHJlYWRzIHdvbid0IGZpZGRsZSB3aXRoIHRoZSB2bm9kZSB1bnRpbCB0aGlzDQpm dW5jdGlvbiBpcyBkb25lIHdpdGggaXQsIGJ1dCBJIGFtIG5vdCBzdXJlPw0KDQpJIHRoaW5rIGEg bW9yZSBjb3JyZWN0IHZlcnNpb24gb2YgdGhpcyAobm90IHNheWluZyBpdCB3b3VsZCBiZSBjb3Jy ZWN0W/CfmIldLA0Kd291bGQgY2FsbCBpbnNtbnRxdWUoKSBsYXRlciBpbiB0aGUgZnVuY3Rpb24s IGFmdGVyIGl0IGhhcyBiZWVuIGluaXRpYWxpemVkLg0KKFRoaXMgbWVhbnMgdGhhdCB0aGUgY2xl YW51cCBpZiBpdCBmYWlscyBpcyBtb3JlIGludm9sdmVkLCBidXQuLi4pDQoNCkkndmUgYXR0YWNo ZWQgYSBwYXRjaCAodW50ZXN0ZWQpIHRoYXQgZG9lcyB0aGlzLiBNYXliZSB5b3UgY291bGQgdHJ5 IGl0Pw0KDQpyaWNrDQpwczogSSd2ZSBjYydkIEtvc3RpaywgaW4gY2FzZSBoZSBoYXMgc29tZSBp bnNpZ2h0IHcuci50LiBob3cgdGhpcyBzaG91bGQgYmUgaGFuZGxlZD8NCg0K --_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_ Content-Type: application/octet-stream; name="unionfs-newvnode.patch" Content-Description: unionfs-newvnode.patch Content-Disposition: attachment; filename="unionfs-newvnode.patch"; size=1549; creation-date="Thu, 11 Aug 2016 22:52:48 GMT"; modification-date="Thu, 11 Aug 2016 22:52:48 GMT" Content-Transfer-Encoding: base64 LS0tIGZzL3VuaW9uZnMvdW5pb25fc3Vici5jLnNhdgkyMDE2LTA4LTExIDE4OjIwOjEwLjU4NTk5 OTAwMCAtMDQwMAorKysgZnMvdW5pb25mcy91bmlvbl9zdWJyLmMJMjAxNi0wOC0xMSAxODo0MDo1 MS4xMTkyMjAwMDAgLTA0MDAKQEAgLTI1NSwxMSArMjU1LDYgQEAgdW5pb25mc19ub2RlZ2V0KHN0 cnVjdCBtb3VudCAqbXAsIHN0cnVjdAogCQlmcmVlKHVucCwgTV9VTklPTkZTTk9ERSk7CiAJCXJl dHVybiAoZXJyb3IpOwogCX0KLQllcnJvciA9IGluc21udHF1ZSh2cCwgbXApOwkvKiBYWFg6IFRv byBlYXJseSBmb3IgbXBzYWZlIGZzICovCi0JaWYgKGVycm9yICE9IDApIHsKLQkJZnJlZSh1bnAs IE1fVU5JT05GU05PREUpOwotCQlyZXR1cm4gKGVycm9yKTsKLQl9CiAJaWYgKGR2cCAhPSBOVUxM VlApCiAJCXZyZWYoZHZwKTsKIAlpZiAodXBwZXJ2cCAhPSBOVUxMVlApCkBAIC0yOTMsNiArMjg4 LDI4IEBAIHVuaW9uZnNfbm9kZWdldChzdHJ1Y3QgbW91bnQgKm1wLCBzdHJ1Y3QKIAkgICAgKGxv d2VydnAgIT0gTlVMTFZQICYmIHVtcC0+dW1fbG93ZXJ2cCA9PSBsb3dlcnZwKSkKIAkJdnAtPnZf dmZsYWcgfD0gVlZfUk9PVDsKIAorCS8qCisJICogTm90IHN1cmUgaWYgTEtfUkVUUlkgaXMgbmVl ZGVkIGhlcmU/CisJICogTm9ybWFsbHksIHRoaXMgd291bGQgYmUgZG9uZSB3aXRoIGEgbG9ja21n cigpIGNhbGwsIGJ1dCBpbgorCSAqIHRoaXMgY2FzZSwgdl92bmxvY2sgaXMgYWN0dWFsbHkgYSB2 bm9kZSBsb2NrIGZvciBlaXRoZXIgdGhlCisJICogdXBwZXJ2cCBvciBsb3dlcnZwLCBzbyBJIHVz ZWQgdGhlIHZuX2xvY2soKSBjYWxsLgorCSAqLworCXZuX2xvY2sodnAsIExLX0VYQ0xVU0lWRSB8 IExLX1JFVFJZKTsKKwllcnJvciA9IGluc21udHF1ZSh2cCwgbXApOworCWlmIChlcnJvciAhPSAw KSB7CisJCWlmIChkdnAgIT0gTlVMTFZQKQorCQkJdnJlbGUoZHZwKTsKKwkJaWYgKHVwcGVydnAg IT0gTlVMTFZQKQorCQkJdnJlbGUodXBwZXJ2cCk7CisJCWlmIChsb3dlcnZwICE9IE5VTExWUCkK KwkJCXZyZWxlKGxvd2VydnApOworCQlmcmVlKHVucC0+dW5faGFzaHRibCwgTV9VTklPTkZTSEFT SCk7CisJCWZyZWUodW5wLT51bl9wYXRoLCBNX1VOSU9ORlNQQVRIKTsKKwkJZnJlZSh1bnAsIE1f VU5JT05GU05PREUpOworCQlyZXR1cm4gKGVycm9yKTsKKwl9CisJVk9QX1VOTE9DSyh2cCwgMCk7 CisKIAlpZiAocGF0aCAhPSBOVUxMICYmIGR2cCAhPSBOVUxMVlAgJiYgdnQgPT0gVkRJUikKIAkJ KnZwcCA9IHVuaW9uZnNfaW5zX2NhY2hlZF92bm9kZSh1bnAsIGR2cCwgcGF0aCk7CiAJaWYgKCgq dnBwKSAhPSBOVUxMVlApIHsKQEAgLTMxNCw2ICszMzEsNyBAQCB1bmlvbmZzX25vZGVnZXQoc3Ry dWN0IG1vdW50ICptcCwgc3RydWN0CiAKIHVuaW9uZnNfbm9kZWdldF9vdXQ6CiAJaWYgKGxrZmxh Z3MgJiBMS19UWVBFX01BU0spCisJCS8qIFNob3VsZCB0aGVyZSBiZSBhIGNoZWNrIGZvciBWSV9E T09NRUQgaGVyZT8gKi8KIAkJdm5fbG9jayh2cCwgbGtmbGFncyB8IExLX1JFVFJZKTsKIAogCXJl dHVybiAoMCk7Cg== --_006_YTOPR01MB0412B2A08F1A3C1A3B2EB160DD1E0YTOPR01MB0412CANP_--