From owner-freebsd-arch@freebsd.org Fri Sep 30 11:53:56 2016 Return-Path: Delivered-To: freebsd-arch@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B4069C0375B for ; Fri, 30 Sep 2016 11:53:56 +0000 (UTC) (envelope-from lew@perftech.com) Received: from smtp-gw.pt.net (smtp-gw.pt.net [206.210.194.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp-gw.pt.net", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89A3E1BF9 for ; Fri, 30 Sep 2016 11:53:55 +0000 (UTC) (envelope-from lew@perftech.com) X-ASG-Debug-ID: 1475236373-09411a12c010e4d90001-RYubVt Received: from mail.pt.net (mail.pt.net [206.210.194.11]) by smtp-gw.pt.net with ESMTP id 2TdVXpHKQ5RDSH5u (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 30 Sep 2016 06:52:53 -0500 (CDT) X-Barracuda-Envelope-From: lew@perftech.com X-Barracuda-Effective-Source-IP: mail.pt.net[206.210.194.11] X-Barracuda-Apparent-Source-IP: 206.210.194.11 Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 4DC268425E9; Fri, 30 Sep 2016 06:52:53 -0500 (CDT) Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id L1rTn71XWvVE; Fri, 30 Sep 2016 06:52:53 -0500 (CDT) Received: from localhost (localhost [IPv6:::1]) by mail.pt.net (Postfix) with ESMTP id 1DEDB8425EA; Fri, 30 Sep 2016 06:52:53 -0500 (CDT) X-Virus-Scanned: amavisd-new at pt.net Received: from mail.pt.net ([IPv6:::1]) by localhost (mail.pt.net [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id Xf4wcOOxoC5n; Fri, 30 Sep 2016 06:52:53 -0500 (CDT) Received: from lewhome-dhcp-179.pt.net (lewhome-dhcp-179.pt.net [206.210.207.179]) (Authenticated sender: lew@pt.net) by mail.pt.net (Postfix) with ESMTPSA id DE5138425E9; Fri, 30 Sep 2016 06:52:52 -0500 (CDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 From: Lewis Donzis X-ASG-Orig-Subj: Re: mq on kqueue broken after upgrade to FreeBSD 11 In-Reply-To: <20160930094544.GP38409@kib.kiev.ua> Date: Fri, 30 Sep 2016 06:52:52 -0500 Cc: freebsd-arch@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.3124) X-Barracuda-Connect: mail.pt.net[206.210.194.11] X-Barracuda-Start-Time: 1475236373 X-Barracuda-Encrypted: ECDHE-RSA-AES256-GCM-SHA384 X-Barracuda-URL: https://smtp-gw.pt.net:443/cgi-mod/mark.cgi X-Barracuda-Scan-Msg-Size: 1235 X-Virus-Scanned: by bsmtpd at pt.net X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests=BSF_SC0_MISMATCH_TO X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.33347 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- 0.00 BSF_SC0_MISMATCH_TO Envelope rcpt doesn't match header X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Sep 2016 11:53:56 -0000 > On Sep 30, 2016, at 4:45 AM, Konstantin Belousov = wrote: > Where was a discussion about the function presence being the mistake ? I think it was here: = https://lists.freebsd.org/pipermail/freebsd-current/2015-November/058706.h= tml which was just about a year ago. Perhaps I=E2=80=99m reading it wrong, = but it seems like the implication is that removing the symbol from being = exported was a "fix", where DE says "Why do the tests in = tests/sys/mqueue/ try to use non-public APIs?" and then later, "symbol = versioning for librt was broken and leaking symbols that shouldn't have = been leaked." > In r291439, symbol versioning for librt was fixed, and apparently > __mq_oshandle() is not present in the global symbols list for librt. > I suspect that this is an erronous ommission, since the function' > declaration is present in the mqueue.h header and it is used by some > mqueue tests. >=20 > As such, I believe that exporting it is the intended option there. > The following patch should fix the problem for you. That makes sense, and appreciate the patch, but just to be clear, does = your change get committed so that we won=E2=80=99t have to re-apply it = after future updates/upgrades? Thanks, lew