Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 16 Apr 2016 13:38:16 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Michael Reifenberger <mr@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r413435 - in head/cad/kicad-devel: . files
Message-ID:  <57122428.3000208@marino.st>
In-Reply-To: <201604161122.u3GBMsPv049894@repo.freebsd.org>
References:  <201604161122.u3GBMsPv049894@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4/16/2016 1:22 PM, Michael Reifenberger wrote:
> Author: mr
> Date: Sat Apr 16 11:22:54 2016
> New Revision: 413435
> URL: https://svnweb.freebsd.org/changeset/ports/413435
>
> Log:
>    Try to fix comilation under FreeBSD-9
>
> Added:
>    head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h   (contents, props changed)
> Modified:
>    head/cad/kicad-devel/Makefile
>
> Modified: head/cad/kicad-devel/Makefile
> ==============================================================================
> --- head/cad/kicad-devel/Makefile	Sat Apr 16 11:22:53 2016	(r413434)
> +++ head/cad/kicad-devel/Makefile	Sat Apr 16 11:22:54 2016	(r413435)
> @@ -3,7 +3,7 @@
>
>   PORTNAME=	kicad
>   DISTVERSION=	r${BZR_SRC_REV}
> -#PORTREVISION=	1
> +PORTREVISION=	1
>   CATEGORIES=	cad
>   MASTER_SITES=	LOCAL/mr
>   PKGNAMESUFFIX=	-devel
>
> Added: head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h
> ==============================================================================
> --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> +++ head/cad/kicad-devel/files/patch-include-gal-graphics_abstraction_layer.h	Sat Apr 16 11:22:54 2016	(r413435)
> @@ -0,0 +1,8 @@
> +--- include/gal/graphics_abstraction_layer.h.orig	2016-04-16 13:14:32.003824016 +0200
> ++++ include/gal/graphics_abstraction_layer.h	2016-04-16 13:15:06.143789160 +0200
> +@@ -31,4 +31,5 @@
> + #include <stack>
> + #include <limits>
> ++#include <cmath>
> +
> + #include <math/matrix3x3.h>
>

Why bump PORTREVISION?
For all those platforms that kicad-devel built on, now they have to 
rebuild it again completely unnecessarily.

In my opinion, this change did not warrant a PORTREVISION bump.

John





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?57122428.3000208>