Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 12 Oct 2005 09:12:58 +0200 (CEST)
From:      Harti Brandt <hartmut.brandt@dlr.de>
To:        Kris Kennaway <kris@obsecurity.org>
Cc:        ports@FreeBSD.org, re@FreeBSD.org
Subject:   Re: Make broken in 6.0 ([ports-i386@pointyhat.freebsd.org: empire-1.7 failed on i386 6])
Message-ID:  <20051012090453.N63649@beagle.kn.op.dlr.de>
In-Reply-To: <20051012021112.GA48078@xor.obsecurity.org>
References:  <20051012020023.GB40204@xor.obsecurity.org> <20051012021112.GA48078@xor.obsecurity.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 11 Oct 2005, Kris Kennaway wrote:

KK>On Tue, Oct 11, 2005 at 10:00:24PM -0400, Kris Kennaway wrote:
KK>> For some reason a number of ports are failing with this error on the
KK>> latest build.  I suspect that a change may have been merged to some
KK>> part of the base system that broke them.  Can someone please take a
KK>> look?

I actually doubt that the $(shell ...) construct was ever supported in our 
make. The canonical way to assign the output of a shell command to a 
variable is

VERSION != sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p'

we also support the SysV syntax:

VERSION :sh= ...

although that's not documented and should be avoided.

harti

KK>> 
KK>> Kris
KK>
KK>> ===>  Configuring for empire-1.7
KK>> ===>  Building for empire-1.7
KK>> Unknown modifier ' '
KK>> 
KK>> Error expanding embedded variable.
KK>> *** Error code 2
KK>
KK>This seems to be from make trying to execute a $(shell ...) command.
KK>This seems to be broken:
KK>
KK>VERSION=$(shell sed <bs.spec -n -e '/Version: \(.*\)/s//\1/p')
KK>
KK>xor# make -V VERSION
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>Unknown modifier ' '
KK>
KK>PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP
KK>+PPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPPP:.*
KK>
KK>I think this must have been broken in make(1) some time ago (if it
KK>ever worked)..the workaround for now is probably to make these ports
KK>use gmake instead [1].
KK>
KK>Kris
KK>
KK>[1] jasone actually discovered this when I was testing some of his
KK>other patches, which flagged this more explicitly as an error.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051012090453.N63649>