From owner-svn-src-all@freebsd.org Fri Dec 4 19:01:42 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DBB9FA41A5B; Fri, 4 Dec 2015 19:01:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B77881967; Fri, 4 Dec 2015 19:01:42 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B4F36B9BE; Fri, 4 Dec 2015 14:01:41 -0500 (EST) From: John Baldwin To: Andrew Turner Cc: Bruce Evans , Bryan Drewery , "Kenneth D. Merry" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291741 - head/sys/geom Date: Fri, 04 Dec 2015 09:57:06 -0800 Message-ID: <33766691.xPhVgrKQoK@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.2-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20151204125355.6712d782@bender> References: <201512040338.tB43cZY1053263@repo.freebsd.org> <20151204233052.J2220@besplex.bde.org> <20151204125355.6712d782@bender> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Fri, 04 Dec 2015 14:01:41 -0500 (EST) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2015 19:01:43 -0000 On Friday, December 04, 2015 12:53:55 PM Andrew Turner wrote: > On Fri, 4 Dec 2015 23:42:51 +1100 (EST) > Bruce Evans wrote: > ... > > This looks like 5 style bugs and 0 issues: > > > > 3 old style bugs: > > - use of bool > > I don't seem to see where in style(9) we disallow the use of bool. Can > you point me where this is specified? Honestly I prefer bool for real booleans to 0/1. I think it is clearer to the reader. I'd like to axe boolean_t and replace its uses with bool. -- John Baldwin