From owner-cvs-src@FreeBSD.ORG Fri Jul 8 21:30:57 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C75CC16A41C; Fri, 8 Jul 2005 21:30:57 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from harmony.village.org (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7298243D48; Fri, 8 Jul 2005 21:30:57 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [127.0.0.1]) by harmony.village.org (8.13.3/8.13.3) with ESMTP id j68LSH61022288; Fri, 8 Jul 2005 15:28:17 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 08 Jul 2005 15:28:23 -0600 (MDT) Message-Id: <20050708.152823.132414307.imp@bsdimp.com> To: scottl@samsco.org From: "M. Warner Losh" In-Reply-To: <42CEEF12.4070904@samsco.org> References: <200507081837.j68Ib0IM082223@repoman.freebsd.org> <42CECCD8.5070201@portaone.com> <42CEEF12.4070904@samsco.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rik@FreeBSD.org, cvs-src@FreeBSD.org, sobomax@portaone.com, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/ndis subr_ntoskrnl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2005 21:30:57 -0000 In message: <42CEEF12.4070904@samsco.org> Scott Long writes: : Maxim Sobolev wrote: : > Roman Kurakin wrote: : > : >> rik 2005-07-08 18:36:59 UTC : >> : >> FreeBSD src repository : >> : >> Modified files: : >> sys/compat/ndis subr_ntoskrnl.c Log: : >> Use implicit type cast for ->k_lock to fix compilation of ndis : >> as a part of the GENERIC kernel with INVARIANT* and WITNESS* : >> turned off. : > : > : > I think the better fix is to change type of k_lock member from void* to : > the struct mtx*, I've already commited such change to the RELENG_5 few : > days ago. : > : > -Maxim : : It's a void* for portability with other OS's. This work has already : been ported : to Solaris, and maybe even other OS's by now. Reducing the portability is a : bad idea, and will likely get you smacked around by Bill when he : notices. I'd : highly recommend not doing this again in the future. And once Bill gets done with you, Paul will have his turn :-) Warner (If that doesn't get me smacked, I don't know what will)