Date: Mon, 20 Feb 2006 10:38:42 +0100 From: Marius Strobl <marius@alchemy.franken.de> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/security/ssh2 Makefile pkg-message pkg-plist ports/security/ssh2/files patch-apps::ssh::Makefile.in patch-apps::ssh::sshd2_config patch-apps::ssh::sshfilecopy.c patch-startup::solaris::sshd2 sshd2.sh.in Message-ID: <20060220103842.D53619@newtrinity.zeist.de> In-Reply-To: <20060220085816.GA88075@xor.obsecurity.org>; from kris@obsecurity.org on Mon, Feb 20, 2006 at 03:58:17AM -0500 References: <200602192256.k1JMuZMU011544@repoman.freebsd.org> <20060219231051.GA70104@xor.obsecurity.org> <20060220093915.C53619@newtrinity.zeist.de> <20060220085816.GA88075@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Feb 20, 2006 at 03:58:17AM -0500, Kris Kennaway wrote: > On Mon, Feb 20, 2006 at 09:39:15AM +0100, Marius Strobl wrote: > > On Sun, Feb 19, 2006 at 06:10:51PM -0500, Kris Kennaway wrote: > > > On Sun, Feb 19, 2006 at 10:56:35PM +0000, Marius Strobl wrote: > > > > marius 2006-02-19 22:56:35 UTC > > > > > > > > FreeBSD ports repository (src committer) > > > > > > > > Modified files: > > > > security/ssh2 Makefile pkg-message pkg-plist > > > > security/ssh2/files patch-apps::ssh::Makefile.in > > > > patch-apps::ssh::sshd2_config > > > > Added files: > > > > security/ssh2/files patch-apps::ssh::sshfilecopy.c > > > > sshd2.sh.in > > > > Removed files: > > > > security/ssh2/files patch-startup::solaris::sshd2 > > > > Log: > > > > - Switch to a rc.d startup script. > > > > - Move the generation of the host key (if not present) from the package/ > > > > port installation to the startup script in order to be in line with > > > > what the base OpenSSH and the OpenSSH-portable port do. > > > > > > Thanks, this should fix the long-standing pkg-plist errors. > > > > > > > Yes, the package builders should no longer report left over files > > as a side-effect. But is a port really required to clean up such > > files, i.e. files like modified config files, certificates, etc > > that in a real installation aren't removed on deinstall but the > > user is informed to remove manually, in the package building > > environment? > > Yes :) The less manual work for the user the better, so when the files > are unchanged from the "default" versions they should be removed > automatically. > Well, that's what the ssh2 port did and does as far as possible, i.e. for the config files. But generally if there's any host specific file which is automatically created during install of the port (host key, certificate, config file with ip address, ...), i.e. files were there's nothing like a "default" version and which you also don't want to re-generate with every update of an already installed port, do these really need to be wrapped in #ifndef PACKAGE_BUILDING, moved to the startup script, etc or can the warnings from the package builders just be ignored? In the case of the ssh2 port and the host key files this IMO wasn't an actual error as you don't want them to end up in the resulting package and for the deinstall of a real installation the user is informed to manually remove them if not just updating to a new version of the port. Marius -- This mail was scanned by AntiVir Milter. This product is licensed for non-commercial use. See www.antivir.de for details.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060220103842.D53619>