Date: Sun, 10 Dec 2017 13:34:14 +0100 From: Wolfram Schneider <wosch@freebsd.org> To: Mathieu Arnold <mat@mat.cc>, Wolfram Schneider <wosch@freebsd.org> Cc: doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org Subject: Re: svn commit: r51065 - head/share/mk Message-ID: <CAMWY7CA8%2B9UcWi4%2BPP8stqQdsVEF%2B8str07k2sA2GmjWjWDxSA@mail.gmail.com> In-Reply-To: <51fe9e8a-9bcc-4929-5774-b0efb6cf51cc@mat.cc> References: <201710061044.v96Ai0We005019@repo.freebsd.org> <a1df01d9-7172-daf7-fa84-ac6f6a2395c8@mat.cc> <CAMWY7CCyVbSJ1jbxSteSMkA-mZ4o5F0nkPqigdav9iuGs-yf0g@mail.gmail.com> <51fe9e8a-9bcc-4929-5774-b0efb6cf51cc@mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 December 2017 at 12:34, Mathieu Arnold <mat@mat.cc> wrote: > Le 01/12/2017 =C3=A0 17:44, Wolfram Schneider a =C3=A9crit : >> On 29 November 2017 at 15:53, Mathieu Arnold <mat@mat.cc> wrote: >>> Le 06/10/2017 =C3=A0 12:44, Wolfram Schneider a =C3=A9crit : >>>> Author: wosch >>>> Date: Fri Oct 6 10:44:00 2017 >>>> New Revision: 51065 >>>> URL: https://svnweb.freebsd.org/changeset/doc/51065 >>>> >>>> Log: >>>> 'make obj' doesn't really work for the docs, disable it by default >>>> >>>> PR: 222488 >>> >>> It does if you run: >>> >>> make obj && make objlink && make <whatever you want> >>> >>> now I have to carry a local patch that arcanist keeps complaining about= :( >> what is arcanist and where does we use it in the documentation build? >> At which point our build process depends on "obj"? > > Unless I misunderstand how all this works, using MAKEOBJDIRPREFIX > requires obj. I work on different branches at the same time, so I set: > > current_branch=3D$(git rev-parse --abbrev-ref HEAD) > export MAKEOBJDIRPREFIX=3D/tmp/doc/${current_branch}/obj > > to make sure the different branches are build in different places. > >> BTW, I didn't removed the obj code. It is just disabled by default for >> the doc project. You can enable it again by setting the env variables. > > > The only way to re-enable the objcode is to remove that line. Which then > makes my checkout unclean, which many tools complain about. (arcanist > being one of them, but git svn complains too.) I checked /usr/share/mk/bsd.obj.mk . The file does a test if NO_OBJ is defined, not about the value. So, you cannot unset it on the command line with: $ make NO_OBJ=3D"" or $ export NO_OBJ=3D""; make It is unlikely this will be get fixed soon. I will revert my change. PS: I still think that 'make obj' doesn't really work for the doc project. But for now, you have to disable it yourself on the command line or in your ~/.profile. -Wolfram --=20 Wolfram Schneider <wosch@FreeBSD.org> https://wolfram.schneider.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMWY7CA8%2B9UcWi4%2BPP8stqQdsVEF%2B8str07k2sA2GmjWjWDxSA>