From owner-freebsd-ipfw Mon Jan 20 16:43:59 2003 Delivered-To: freebsd-ipfw@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DD7C937B401 for ; Mon, 20 Jan 2003 16:43:57 -0800 (PST) Received: from arthur.nitro.dk (port324.ds1-khk.adsl.cybercity.dk [212.242.113.79]) by mx1.FreeBSD.org (Postfix) with ESMTP id 67D5D43EB2 for ; Mon, 20 Jan 2003 16:43:57 -0800 (PST) (envelope-from simon@arthur.nitro.dk) Received: by arthur.nitro.dk (Postfix, from userid 1000) id 4E04C10BF8B; Tue, 21 Jan 2003 01:43:54 +0100 (CET) Date: Tue, 21 Jan 2003 01:43:54 +0100 From: "Simon L. Nielsen" To: freebsd-ipfw@FreeBSD.ORG Subject: Sanity check in ipfw(8) Message-ID: <20030121004353.GF351@nitro.dk> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tmoQ0UElFV5VgXgH" Content-Disposition: inline User-Agent: Mutt/1.5.1i Sender: owner-freebsd-ipfw@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --tmoQ0UElFV5VgXgH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello I recently found a problem where ipfw2 would allow the user to create firewall rules that does not make sense like (notice udp and setup) : ipfw add allow udp from any to any setup I filed a PR (bin/47120) with a "fix" since I thought this was a trivial change to check in the ipfw userland program for protocol when specifying options like setup, icmpoptions and the likes. The fix is not correct since I did not notice that it is possible to use multiple protocols with or statements. Now for the point :-)... Is it interesting to have the extra sanity check in ipfw(8) ? If it is I will try to make a patch that actually works, but if it isn't there is not much reason to make a new patch... Btw. could a committer take a quick look at bin/46785 which is a trivial change to ipfw -h. --=20 Simon L. Nielsen --tmoQ0UElFV5VgXgH Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+LJfJ8kocFXgPTRwRAjiRAKDFQbHvu/JsBWpaYfnnFeByUN1hKgCdFkQe 1Ocyh0OoEpye9wC5u/frlhk= =W8z8 -----END PGP SIGNATURE----- --tmoQ0UElFV5VgXgH-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ipfw" in the body of the message