Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Nov 1998 11:43:09 -0800
From:      Mike Smith <mike@smith.net.au>
To:        Terry Lambert <tlambert@primenet.com>
Cc:        mike@smith.net.au (Mike Smith), grog@lemis.com, ticso@cicely.de, peter.jeremy@auss2.alcatel.com.au, hackers@FreeBSD.ORG
Subject:   Re: [Vinum] Stupid benchmark: newfsstone 
Message-ID:  <199811151943.LAA13781@dingo.cdrom.com>
In-Reply-To: Your message of "Sun, 15 Nov 1998 19:16:01 GMT." <199811151916.MAA27750@usr07.primenet.com> 

next in thread | previous in thread | raw e-mail | index | archive | help
> > > > I'll tell you what: anybody who wants, go and look at the request
> > > > building code in /usr/src/lkm/vinum/request.c and rebuild it to
> > > > perform the "aggregation" optimizations that Bernd wants, and I'll
> > > > put it into the code.
> > > 
> > > RAIDFrame was built as a research tool to allow people to test
> > > out just such theories, with the minimum amount of code, and no
> > > modification required to the framework in which the code runs.
> > > 
> > > It's acutally the right tool for the job of testing these ideas
> > > out.
> > 
> > ... it was also imported into NetBSD on the 12th.
> > 
> > What's most irritating is that the vast majority of the diffs between 
> > the original RAIDframe code and the version imported into the NetBSD 
> > tree are noise - formatting, prototypes, etc.
> > 
> > The actual meat is pretty trivial, but it makes me wonder who actually 
> > reviewed the code, and what their criteria were...
> 
> Ugh.
> 
> I know that the patch set I made was just to make the thing compile;
> the author assured me that it would be rolled into the next release.
> I'm not sure whether my patches on freebsd.org are redundant yet, or
> not.

I haven't looked at your diffs; I guess I should.

> Maybe the formatting changes came from a next release of the code?

Not according to the committer's website; he took the 1.1 release, 
bashed it sideways into the NetBSD kernel and committed it.

-- 
\\  Sometimes you're ahead,       \\  Mike Smith
\\  sometimes you're behind.      \\  mike@smith.net.au
\\  The race is long, and in the  \\  msmith@freebsd.org
\\  end it's only with yourself.  \\  msmith@cdrom.com



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199811151943.LAA13781>