From owner-cvs-all Mon Aug 6 8:15:47 2001 Delivered-To: cvs-all@freebsd.org Received: from ipcard.iptcom.net (ipcard.iptcom.net [212.9.224.5]) by hub.freebsd.org (Postfix) with ESMTP id F147C37B401; Mon, 6 Aug 2001 08:15:35 -0700 (PDT) (envelope-from sobomax@FreeBSD.org) Received: from vega.vega.com (dialup6-34.iptelecom.net.ua [212.9.227.98]) by ipcard.iptcom.net (8.9.3/8.9.3) with ESMTP id SAA02731; Mon, 6 Aug 2001 18:15:28 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Received: from FreeBSD.org (big_brother.vega.com [192.168.1.1]) by vega.vega.com (8.11.4/8.11.3) with ESMTP id f76FEvV61028; Mon, 6 Aug 2001 18:14:57 +0300 (EEST) (envelope-from sobomax@FreeBSD.org) Message-ID: <3B6EB49D.87864E16@FreeBSD.org> Date: Mon, 06 Aug 2001 18:15:41 +0300 From: Maxim Sobolev Organization: Vega International Capital X-Mailer: Mozilla 4.78 [en] (Windows NT 5.0; U) X-Accept-Language: en,uk,ru MIME-Version: 1.0 To: Dima Dorfman Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, phk@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/md md.c References: <20010803202216.30EB13E31@bazooka.unixfreak.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dima Dorfman wrote: > Maxim Sobolev writes: > > sobomax 2001/08/02 03:19:14 PDT > > > > Modified files: > > sys/dev/md md.c > > Log: > > - Deny detaching requests until device is still open, otherwise it is possible > > to hang or panic kernel by detaching disk from which fs is mounted; > > When I proposed a similar patch some time ago, phk said that he would > like md(4) to behave "as much like a real disk as possible", which > included being able to go offline at any moment (in md terms, this > would mean detaching). This would be useful for testing such things > as a removable ATA flash drive going away. > > That said, detaching an md while it's mounted is only going to bite > more people as more people start using -current (esp. when it comes > closer to being -release), so this safeguard is a good idea. However, > it would still be nice to be able to turn it off when one wishes. I > propose to add a "force" option that will tell the driver to turn off > anti-foot shooting precautions such as this one. Attached is a patch > to do that. > > Comments? Thoughts? Looks fine to me. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message