From owner-cvs-all  Tue Apr 27  6:22: 0 1999
Delivered-To: cvs-all@freebsd.org
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.40.153])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5C63914E34; Tue, 27 Apr 1999 06:21:04 -0700 (PDT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131])
	by phk.freebsd.dk (8.9.1/8.8.8) with ESMTP id PAA21982;
	Tue, 27 Apr 1999 15:20:40 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.9.2/8.9.2) with ESMTP id PAA19639;
	Tue, 27 Apr 1999 15:20:32 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Bruce Evans <bde@zeta.org.au>
Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha cons.c mem.c promcons.c sys_machdep.c src/sys/alpha/tlsb zs_tlsb.c src/sys/dev/ata atapi-cd.c src/sys/dev/en midway.c src/sys/dev/syscons syscons.c src/sys/dev/vinum vinum.c src/sys/dev/vn vn.c src/sys/gnu/ext2fs ... 
In-reply-to: Your message of "Tue, 27 Apr 1999 22:39:33 +1000."
             <199904271239.WAA23086@godzilla.zeta.org.au> 
Date: Tue, 27 Apr 1999 15:20:31 +0200
Message-ID: <19637.925219231@critter.freebsd.dk>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

In message <199904271239.WAA23086@godzilla.zeta.org.au>, Bruce Evans writes:
>>  Suser() simplification:
>
>I thought we decided that this was too painful.

I've grown thicker skin :-)

It was actually not that bad after all, and we will have more
and worse changes between 3.X and 4.0 than this.

I have just cleaned up the immediately obvious bogons, and there
are 30 calls to suser_xxx() left now, most of which seem correct
to me (filesystems mostly).

The next step will probably not happen until I commit the jail 
code, then I will change suser_xxx() to:

	suser_xxx(struct proc *, struct ucred *, int flags)

and work something like:

	if (!cred && !proc)
		panic("THINK!");
	if (!cred)
		cred = proc->p_ucred
	...

The flags will be used to determined if jailed roots are OK.

--
Poul-Henning Kamp             FreeBSD coreteam member
phk@FreeBSD.ORG               "Real hackers run -current on their laptop."
FreeBSD -- It will take a long time before progress goes too far!


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message