Date: Tue, 12 Aug 2014 13:28:46 +0000 (UTC) From: Andrey A. Chernov <ache@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r269875 - head/lib/libpam/modules/pam_opie Message-ID: <53ea168e.6811.1ab9cea0@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: ache Date: Tue Aug 12 13:28:46 2014 New Revision: 269875 URL: http://svnweb.freebsd.org/changeset/base/269875 Log: According to opie code and even direct mention in opie(4) challenge buffer size must be OPIE_CHALLENGE_MAX + 1, not OPIE_CHALLENGE_MAX Reviewed by: des MFC after: 1 week Modified: head/lib/libpam/modules/pam_opie/pam_opie.c Modified: head/lib/libpam/modules/pam_opie/pam_opie.c ============================================================================== --- head/lib/libpam/modules/pam_opie/pam_opie.c Tue Aug 12 13:13:11 2014 (r269874) +++ head/lib/libpam/modules/pam_opie/pam_opie.c Tue Aug 12 13:28:46 2014 (r269875) @@ -62,7 +62,7 @@ pam_sm_authenticate(pam_handle_t *pamh, struct passwd *pwd; int retval, i; const char *(promptstr[]) = { "%s\nPassword: ", "%s\nPassword [echo on]: "}; - char challenge[OPIE_CHALLENGE_MAX]; + char challenge[OPIE_CHALLENGE_MAX + 1]; char principal[OPIE_PRINCIPAL_MAX]; const char *user; char *response;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53ea168e.6811.1ab9cea0>