Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 17 Aug 2014 12:19:28 -0700
From:      yaneurabeya@gmail.com
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Garrett Cooper <ngie@freebsd.org>
Subject:   Re: svn commit: r269505 - head/libexec/rtld-elf/tests/target
Message-ID:  <3AC76F65-8A5A-407C-B24C-267DB489EF0E@gmail.com>
In-Reply-To: <F63D0031-AE8E-4125-96F1-9879C959F75D@gmail.com>
References:  <53df1ed9.5830.34b38bca@svn.freebsd.org> <20140804185707.P7764@besplex.bde.org> <F63D0031-AE8E-4125-96F1-9879C959F75D@gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_B1B7AB72-E60E-4559-AE5E-31D16EE3C5F2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=windows-1252


On Aug 4, 2014, at 10:24 AM, Garrett Cooper <yaneurabeya@gmail.com> =
wrote:

> Hi Bruce!
>=20
> On Aug 4, 2014, at 2:23 AM, Bruce Evans <brde@optusnet.com.au> wrote:
>=20
>> On Mon, 4 Aug 2014, Garrett Cooper wrote:
>=20
> ...
>=20
>> I hope this fixes the error found by "make checkdpadd".  -L is too =
hard
>> for the current "make checkdpadd" to handle.  Old aout versions =
worked
>> better using linker support.  They also found the correct =
dependencies
>> (on shared libraries for shared linkage, not the pseudo-dependenci on
>> the hard-coded static librar for shared linkage).
>=20
> Thank you for the reminder about that make target :).

And this still fails make checkdpadd :(...

>> "make checkdpadd" currently finds broken 143 makefiles with =
inconsistent
>> DPADD.  62 of them are for clang.  Most of these misuse DPADD for
>> headers.  The next largest source of errors is libtermcapw.  =
LIBTERMCAPW
>> is missing in bsd.libnames.mk.  This breaks about 29 makefiles where
>> LIBTERMCAP was blindly replaced by LIBTERMCAPW.  bsd.libnames.mk and
>> DPADD were unnecessary with the old aout versions.
>=20
> I=92ll file bugs for any issues I find and work with maintainers to =
fix the issues. I=92m not sure if you=92re on Phabricator, but I=92d be =
happy to add you to the reviews if you would like.

I filed bugs for the bulk majority of the issues I found with make =
checkdpadd.

Thanks!
-Garrett

--Apple-Mail=_B1B7AB72-E60E-4559-AE5E-31D16EE3C5F2
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org

iQEcBAEBCgAGBQJT8QBAAAoJEMZr5QU6S73e51cIAIJ4GL2n/R5gH3aMmETuVo9S
/QZ7QIU9c8NtU+OWBxdo1KCZWY/6FUbOfaHXCkqsXm+EcWXCrpAPhBMhRdB5PKGc
8pP7CMarSXhsjFjE0oeBPS9+AafawavNXBH645hnPPhf1E9E/VSoPRFjokQ3jOTN
Pp6ZeKqes53q16wMJcgcS/UWj6rUoTxu1n5Xqdb9umf5ALfkeHjRATo6tLdnaCWQ
NskHTe2Aid241JHTJ0VqdwXxrecfbD7SgIpILP9YdPnhkf5dvLkC5g6dbMNsGYFD
UWwiN4ElYCISI/YIXJEjXfIKtRHmVj/iUPFLt4dGy4IyUPglZfthv0jWHtjI5TU=
=qphx
-----END PGP SIGNATURE-----

--Apple-Mail=_B1B7AB72-E60E-4559-AE5E-31D16EE3C5F2--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3AC76F65-8A5A-407C-B24C-267DB489EF0E>