From owner-freebsd-arch@FreeBSD.ORG  Tue Jul 24 19:36:18 2007
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4888A16A419;
	Tue, 24 Jul 2007 19:36:18 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219])
	by mx1.freebsd.org (Postfix) with ESMTP id ADEAD13C457;
	Tue, 24 Jul 2007 19:36:17 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (unverified [66.23.211.162]) 
	by speedfactory.net (SurgeMail 3.7b8) with ESMTP id 198727041 
	for multiple; Tue, 24 Jul 2007 15:44:54 -0400
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l6OJa7bL011539;
	Tue, 24 Jul 2007 15:36:07 -0400 (EDT) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: Robert Watson <rwatson@freebsd.org>
Date: Tue, 24 Jul 2007 15:35:58 -0400
User-Agent: KMail/1.9.6
References: <20070724110908.T83919@fledge.watson.org>
	<200707241107.43047.jhb@freebsd.org>
	<20070724192023.N15979@fledge.watson.org>
In-Reply-To: <20070724192023.N15979@fledge.watson.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707241535.59867.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Tue, 24 Jul 2007 15:36:08 -0400 (EDT)
X-Virus-Scanned: ClamAV 0.88.3/3754/Tue Jul 24 09:41:21 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
X-Server: High Performance Mail Server - http://surgemail.com r=1653887525
Cc: arch@freebsd.org, gnn@freebsd.org, bz@freebsd.org, current@freebsd.og,
	freebsd-arch@freebsd.org
Subject: Re: Removing NET_NEEDS_GIANT: first patch
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jul 2007 19:36:18 -0000

On Tuesday 24 July 2007 02:21:09 pm Robert Watson wrote:
> 
> On Tue, 24 Jul 2007, John Baldwin wrote:
> 
> > On Tuesday 24 July 2007 06:17:45 am Robert Watson wrote:
> >> Patch attached, and also available at this URL:
> >
> > Possibly use mtx_assert() rather than KASSERT(mtx_owned()) in 
> > nfs_syscalls.c?
> 
> Sounds good, I will make that change.  I picked that new structure because 
it 
> most closely matched what was there, and what was there required a KASSERT 
> because it combined a variable check with a lock check, but the new code 
> doesn't require that.

*nod*  I'd figured as much.  I'd of almost prefer that the previous code had 
been:

	if (!debug_mpsafenet)
		mtx_assert(...)

FWIW.

-- 
John Baldwin