Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 03 Jul 2013 19:46:22 -0400
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        Niclas Zeising <zeising@daemonic.se>
Cc:        vbox@freebsd.org, AN <andy@neu.net>, "scottl@FreeBSD.org" <scottl@freebsd.org>, freebsd-ports@freebsd.org
Subject:   Re: !virtualbox-ose (virtualbox-ose-4.2.14) (bad C++ code)
Message-ID:  <51D4B7CE.5010405@FreeBSD.org>
In-Reply-To: <51D4B5C9.8070809@daemonic.se>
References:  <alpine.BSF.2.00.1307031334450.82358@mail.neu.net> <51D4662E.9050503@FreeBSD.org> <51D4B5C9.8070809@daemonic.se>

next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2013-07-03 19:37:45 -0400, Niclas Zeising wrote:
> On 07/03/13 19:58, Jung-uk Kim wrote:
>> On 2013-07-03 13:38:46 -0400, AN wrote:
>>> FreeBSD FBSD10 10.0-CURRENT FreeBSD 10.0-CURRENT #73 r252430:
>>> Sun Jun 30 17:30:59 CDT 2013 
>>> root@FBSD10:/usr/obj/usr/src/sys/MYKERNEL  amd64
>> 
>>> VBox upgrade fails.
>> 
>> 
>> 
>>> In file included from 
>>> /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.2.14/src/VBox/Devices/Storage/DrvHostBase.cpp:105:
>>
>>>
>>> 
/usr/include/cam/cam_ccb.h: In function 'cam_status
>>> cam_ccb_status(ccb*)': /usr/include/cam/cam_ccb.h:1309: error: 
>>> invalid conversion from 'unsigned int' to 'cam_status'
>> ...
>> 
>> This problem was introduced with r252382.  Basically, C
>> compilers don't complain about this implicit casting but C++
>> compilers do not like it at all.  Luckily, it is easy to fix.
>> Please see the attached patch.
> 
> Hi! I'm getting a similar error when compiling
> sysutils/smartmontools, however your proposed patch does not work,
> at least not when compiling with clang.

It works for me, for both clang++ and g++ on head.  I tried
sysutils/smartmontools, too.  Are you sure you have the new header
file in /usr/include/cam? ;-)

Jung-uk Kim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)

iQEcBAEBAgAGBQJR1LfOAAoJECXpabHZMqHOtvUIAKMA2y8USaAJq3QHf9yg8yTX
/wtm1bMU6KRgrGLDPf7JZRkjEoR6N/9LEjQZkPBlJ73WYAHEYL8jUCSrckivKH1w
6sBOXTlO9kmNI2IiktaoU/DQPROvGAI+THnkXHhvT9hQjlz0VnyxRP6lqv2xtNFB
8yxGp2JJrLJjQWUbQX7rDlaSm9T2jDZ5nxKc/VFy+X+TDB7psBegD3/tgIRkQAqw
gT38ZF989K4dtSjDMHa+7OQCGbUA8YZ70hvbZ4SxwJqDNespTPsZe2MpBlQ7yQ67
iagJkakuafH45wO0N7CWfUTjRLrRQb8EIcYlYAGJWj4KLEeqGvIlhdL7rwEUXcs=
=tWj8
-----END PGP SIGNATURE-----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51D4B7CE.5010405>