From owner-freebsd-gnome Thu Nov 7 15:40:19 2002 Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7CA3B37B401 for ; Thu, 7 Nov 2002 15:40:16 -0800 (PST) Received: from creme-brulee.marcuscom.com (rdu57-17-158.nc.rr.com [66.57.17.158]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4457E43E4A for ; Thu, 7 Nov 2002 15:40:15 -0800 (PST) (envelope-from marcus@FreeBSD.org) Received: from [10.2.1.4] (vpn-client-4.marcuscom.com [10.2.1.4]) by creme-brulee.marcuscom.com (8.12.6/8.12.6) with ESMTP id gA7Nc201020947; Thu, 7 Nov 2002 18:38:02 -0500 (EST) (envelope-from marcus@FreeBSD.org) Subject: Re: libgtop broken on -current by latest commit From: Joe Marcus Clarke To: Volker Stolz Cc: gnome@FreeBSD.org In-Reply-To: <20021105112435.GA78160@i2.informatik.rwth-aachen.de> References: <20021105112435.GA78160@i2.informatik.rwth-aachen.de> Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Mailer: Ximian Evolution 1.0.8 Date: 07 Nov 2002 18:40:10 -0500 Message-Id: <1036712411.345.30.camel@gyros.marcuscom.com> Mime-Version: 1.0 X-Spam-Status: No, hits=-5.4 required=5.0 tests=AWL,IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, SPAM_PHRASE_00_01 version=2.41 Sender: owner-freebsd-gnome@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, 2002-11-05 at 06:24, Volker Stolz wrote: > I'm currently wading through libgtop-code on -current, maybe > somebody can lend me a hand? > > A commit two days ago generates invalid C syntax as documented > by bento, it looks like the closing +#endif comes one line too > early: > > +} > +#else > if ((vnode.v_type != VREG) || (vnode.v_tag != VT_UFS) || > +#endif > !vnode.v_data) continue; > > But even if I fix that, my machine complains that there's no variable > "inode" -- which indeed isn't, because it has moved into a version check: > > +#if __FreeBSD_version < 500039 > struct inode inode; > -struct mount mount; > +#endif > > If I remove the #if, the file compiles at least, but I won't even > claim that I know what these changes are for. Fixed. Thanks for reporting. Joe > > Cheers, > Volker > -- > http://www-i2.informatik.rwth-aachen.de/stolz/ *** PGP *** S/MIME > > -- Joe Marcus Clarke FreeBSD GNOME Team :: marcus@FreeBSD.org http://www.FreeBSD.org/gnome To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-gnome" in the body of the message