Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Aug 2009 08:22:47 +0200
From:      Christoph Mallon <christoph.mallon@gmx.de>
To:        Doug Barton <dougb@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r196478 - head/etc
Message-ID:  <4A9231B7.9070204@gmx.de>
In-Reply-To: <200908231952.n7NJqlFg070672@svn.freebsd.org>
References:  <200908231952.n7NJqlFg070672@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Doug Barton schrieb:
> Author: dougb
> Date: Sun Aug 23 19:52:47 2009
> New Revision: 196478
> URL: http://svn.freebsd.org/changeset/base/196478
> 
> Log:
>   Prior to the dire warning about values of network_interfaces other than
>   AUTO the biggest mistake users made was leaving lo0 off the list. Since
>   lo0 is effectively mandatory, check for it and add it to the list if
>   it's not there.
> 
> Modified:
>   head/etc/network.subr
> 
> Modified: head/etc/network.subr
> ==============================================================================
> --- head/etc/network.subr	Sun Aug 23 18:28:58 2009	(r196477)
> +++ head/etc/network.subr	Sun Aug 23 19:52:47 2009	(r196478)
> @@ -727,6 +727,13 @@ list_net_interfaces()
>  		;;
>  	*)
>  		_tmplist="${network_interfaces} ${cloned_interfaces}"
> +
> +		# lo0 is effectively mandatory, so help prevent foot-shooting
> +		#
> +		case "$_tmplist" in
> +		lo0*|*lo0|*' lo0 '*)	;;	# This is fine, do nothing

Doesn't this also match malo0?
IMO the test should be lo0|'lo0 '*|*' lo0'|*' lo0 '*.

	Christoph



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A9231B7.9070204>